After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734695 - Minor patches for review
Minor patches for review
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
1.21.x
Other Linux
: Normal minor
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-12 22:12 UTC by Ross Lagerwall
Modified: 2014-08-14 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
computer: Fix a memory leak (742 bytes, patch)
2014-08-12 22:14 UTC, Ross Lagerwall 		committed Details | Review
daemon: Fix a memory leak (734 bytes, patch)
2014-08-12 22:14 UTC, Ross Lagerwall 		committed Details | Review
afp: Fix some memory leaks (1.49 KB, patch)
2014-08-12 22:14 UTC, Ross Lagerwall 		committed Details | Review
dav: Send enumerate success earlier (1.08 KB, patch)
2014-08-12 22:14 UTC, Ross Lagerwall 		committed Details | Review
gvfs-save: Allow specifying G_FILE_CREATE_REPLACE_DESTINATION (3.10 KB, patch)
2014-08-12 22:14 UTC, Ross Lagerwall 		committed Details | Review

Description Ross Lagerwall 2014-08-12 22:12:35 UTC 
I have a bunch of minor patches that could do with a quick review.
Comment 1 Ross Lagerwall 2014-08-12 22:14:44 UTC 
Created attachment 283235 [details] [review]
computer: Fix a memory leak
Comment 2 Ross Lagerwall 2014-08-12 22:14:47 UTC 
Created attachment 283236 [details] [review]
daemon: Fix a memory leak
Comment 3 Ross Lagerwall 2014-08-12 22:14:52 UTC 
Created attachment 283237 [details] [review]
afp: Fix some memory leaks
Comment 4 Ross Lagerwall 2014-08-12 22:14:55 UTC 
Created attachment 283238 [details] [review]
dav: Send enumerate success earlier

Send a "success" response earlier when enumerating to allow infos to be
sent incrementally rather than batched up until the end.
Comment 5 Ross Lagerwall 2014-08-12 22:14:59 UTC 
Created attachment 283239 [details] [review]
gvfs-save: Allow specifying G_FILE_CREATE_REPLACE_DESTINATION

Allow specifying G_FILE_CREATE_REPLACE_DESTINATION when using gvfs-save
with the -u flag or --unlink.  I chose this because "unlink" represents
what G_FILE_CREATE_REPLACE_DESTINATION does in principle: it unlinks the
destination before replacing it, thereby losing any permissions or other
attributes of the file.
Comment 6 Ondrej Holy 2014-08-14 14:27:08 UTC 
Thanks for those fixes, please commit them :-)
Comment 7 Ross Lagerwall 2014-08-14 17:04:07 UTC 
Pushed to master. Thanks for the review!