After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734682 - Ensure username doesn't have invalid characters
Ensure username doesn't have invalid characters
Status: RESOLVED OBSOLETE
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-12 16:58 UTC by Lasse Schuirmann
Modified: 2018-01-11 10:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
unattended-setup-box: Allow alphanumeric usernames only (2.06 KB, patch)
2014-08-12 16:58 UTC, Lasse Schuirmann
none Details | Review
configure: Require libosinfo >= 0.2.13 (818 bytes, patch)
2015-08-17 18:24 UTC, Zeeshan Ali
none Details | Review
unattended: Ensure username only has valid characters (4.90 KB, patch)
2015-08-17 18:24 UTC, Zeeshan Ali
reviewed Details | Review

Description Lasse Schuirmann 2014-08-12 16:58:33 UTC
E.g. debian express installation fails at least if there is an _ in the username. We should therefore avoid special characters.
Comment 1 Lasse Schuirmann 2014-08-12 16:58:35 UTC
Created attachment 283225 [details] [review]
unattended-setup-box: Allow alphanumeric usernames only

Express installation may fail if non-alphanumeric usernames are
provided. Its best to avoid special characters here.
Comment 2 Zeeshan Ali 2014-10-22 23:58:27 UTC
Review of attachment 283225 [details] [review]:

Would be nice to mention in the log that at least Debian is known to fail.
Comment 3 Zeeshan Ali 2014-10-23 00:02:29 UTC
Review of attachment 283225 [details] [review]:

On second thought, I think this should be handled the same way as product id. libosinfo tells us the format and we ensure that entered text is according to that. For now, lets go with this approach. AFAIK usernames in windows are very liberal so wouldn't be nice to restrict users in that case.
Comment 4 Zeeshan Ali 2014-10-24 14:48:16 UTC
I don't think you (Lasse), me or anyone will manage to fix this in 3.14. Moving to 3.16 target..
Comment 5 Zeeshan Ali 2014-10-24 14:49:32 UTC
(In reply to comment #4)
> I don't think you (Lasse), me or anyone will manage to fix this in 3.14. Moving
> to 3.16 target..

Besides, we'll have to bump libosinfo version for the proper fix for this and that is not desirable in stable version.
Comment 6 Zeeshan Ali 2015-08-12 16:44:11 UTC
Review of attachment 283225 [details] [review]:

Looking into this now but I realized that Boxes part will be likely based on this patch so changing resolution so git-bz can let me apply this patch. :)
Comment 7 Zeeshan Ali 2015-08-17 18:24:10 UTC
Created attachment 309408 [details] [review]
configure: Require libosinfo >= 0.2.13

Let's bump required libosinfo to next release to be able to use the new
API to query the allowed username pattern.
Comment 8 Zeeshan Ali 2015-08-17 18:24:23 UTC
Created attachment 309409 [details] [review]
unattended: Ensure username only has valid characters
Comment 9 Lasse Schuirmann 2015-08-17 18:26:27 UTC
Review of attachment 309409 [details] [review]:

lgtm, together with the libosinfo patches which need to be committed before this. (Thus not marking commit-now)
Comment 10 Christophe Fergeau 2015-08-26 09:56:15 UTC
(In reply to Lasse Schuirmann from comment #9)
> lgtm, together with the libosinfo patches which need to be committed before
> this. (Thus not marking commit-now)

Ideally committed and _released_ to avoid rushing upstream libosinfo on Boxes release day ;)
Comment 11 Zeeshan Ali 2015-08-26 11:36:58 UTC
(In reply to Christophe Fergeau from comment #10)
> (In reply to Lasse Schuirmann from comment #9)
> > lgtm, together with the libosinfo patches which need to be committed before
> > this. (Thus not marking commit-now)
> 
> Ideally committed and _released_ to avoid rushing upstream libosinfo on
> Boxes release day ;)

Of course. It's usually planned though, just fail to communicate the plan to others in time. :)
Comment 12 Zeeshan Ali 2015-09-29 18:28:31 UTC
This needs changes to libosinfo and it won't be a good idea to bump libosinfo requirement in stable cycle.
Comment 13 GNOME Infrastructure Team 2018-01-11 10:10:50 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/31.