GNOME Bugzilla – Bug 734682
Ensure username doesn't have invalid characters
Last modified: 2018-01-11 10:10:50 UTC
E.g. debian express installation fails at least if there is an _ in the username. We should therefore avoid special characters.
Created attachment 283225 [details] [review] unattended-setup-box: Allow alphanumeric usernames only Express installation may fail if non-alphanumeric usernames are provided. Its best to avoid special characters here.
Review of attachment 283225 [details] [review]: Would be nice to mention in the log that at least Debian is known to fail.
Review of attachment 283225 [details] [review]: On second thought, I think this should be handled the same way as product id. libosinfo tells us the format and we ensure that entered text is according to that. For now, lets go with this approach. AFAIK usernames in windows are very liberal so wouldn't be nice to restrict users in that case.
I don't think you (Lasse), me or anyone will manage to fix this in 3.14. Moving to 3.16 target..
(In reply to comment #4) > I don't think you (Lasse), me or anyone will manage to fix this in 3.14. Moving > to 3.16 target.. Besides, we'll have to bump libosinfo version for the proper fix for this and that is not desirable in stable version.
Review of attachment 283225 [details] [review]: Looking into this now but I realized that Boxes part will be likely based on this patch so changing resolution so git-bz can let me apply this patch. :)
Created attachment 309408 [details] [review] configure: Require libosinfo >= 0.2.13 Let's bump required libosinfo to next release to be able to use the new API to query the allowed username pattern.
Created attachment 309409 [details] [review] unattended: Ensure username only has valid characters
Review of attachment 309409 [details] [review]: lgtm, together with the libosinfo patches which need to be committed before this. (Thus not marking commit-now)
(In reply to Lasse Schuirmann from comment #9) > lgtm, together with the libosinfo patches which need to be committed before > this. (Thus not marking commit-now) Ideally committed and _released_ to avoid rushing upstream libosinfo on Boxes release day ;)
(In reply to Christophe Fergeau from comment #10) > (In reply to Lasse Schuirmann from comment #9) > > lgtm, together with the libosinfo patches which need to be committed before > > this. (Thus not marking commit-now) > > Ideally committed and _released_ to avoid rushing upstream libosinfo on > Boxes release day ;) Of course. It's usually planned though, just fail to communicate the plan to others in time. :)
This needs changes to libosinfo and it won't be a good idea to bump libosinfo requirement in stable cycle.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/31.