After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734664 - Bring back the selection menu button
Bring back the selection menu button
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-12 12:39 UTC by Adrien Plazas
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
selection-toolbar: Bring menu button back (1.01 KB, patch)
2014-08-12 12:42 UTC, Adrien Plazas 		needs-work Details | Review
selection-toolbar: Bring menu button back (1.12 KB, patch)
2014-08-12 13:50 UTC, Adrien Plazas 		committed Details | Review
Correct bug reference (845 bytes, patch)
2014-08-12 16:40 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2014-08-12 12:39:11 UTC 
The selection toolbar's menu button have disappeared, we should bring it back.
Comment 1 Adrien Plazas 2014-08-12 12:42:04 UTC 
Created attachment 283183 [details] [review]
selection-toolbar: Bring menu button back
Comment 2 Zeeshan Ali 2014-08-12 12:52:29 UTC 
Review of attachment 283183 [details] [review]:

As usual, I'm fine with patch but log could be improved. :) Sounds like we dropped the button and now we are bringing it back. Mention of work around in details would suffice I guess.
Comment 3 Adrien Plazas 2014-08-12 13:50:36 UTC 
Created attachment 283200 [details] [review]
selection-toolbar: Bring menu button back

The menu button have accidentally disappeared in the 3.13.x cycle, this commit
is a work around to bring it back.
Comment 4 Zeeshan Ali 2014-08-12 15:24:16 UTC 
Review of attachment 283200 [details] [review]:

ACK
Comment 5 Zeeshan Ali 2014-08-12 15:33:03 UTC 
I only realized now (after pushing your patch) that you added the URL to this bug instead of the actual gtk+ bug in the comment :( Can you please fix that.

Attachment 283200 [details] pushed as 25c9a14 - selection-toolbar: Bring menu button back
Comment 6 Adrien Plazas 2014-08-12 16:40:45 UTC 
Created attachment 283223 [details] [review]
Correct bug reference
Comment 7 Zeeshan Ali 2014-08-19 19:55:32 UTC 
Great somehow I ended up pushing the obsolete patch. :( I'll correct the URL in the FIXME then.
Comment 8 Zeeshan Ali 2014-08-19 19:59:05 UTC 
(In reply to comment #7)
> Great somehow I ended up pushing the obsolete patch. :( I'll correct the URL in
> the FIXME then.

NM, got confused (AGAIN :)