After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734648 - Error not handled properly
Error not handled properly
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.x
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-12 09:46 UTC by Anuj
Modified: 2014-08-13 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improved error handling (918 bytes, patch)
2014-08-12 09:46 UTC, Anuj 		rejected Details | Review

Description Anuj 2014-08-12 09:46:26 UTC 
Created attachment 283166 [details] [review]
Improved error handling

In gst-plugin-base/tests/check/pipelines:

oggmux.c handles the error and prints the required error message, but does not make it free after use of *error.
make me correct if i am wrong i have seen i many modules, this needs to be freed.
Adding a patch for same.
thank you.
Comment 1 Sebastian Dröge (slomo) 2014-08-12 10:23:12 UTC 
Review of attachment 283166 [details] [review]:

::: tests/check/pipelines/oggmux.c
@@ +265,3 @@
       error ? error->message : "(invalid error)");
+  if (error != NULL)
+    g_error_free (error);

You can just use g_clear_error(&error) here without the if, however this should be no problem. If there is an error it will fail the test anyway before even reaching these lines
Comment 2 Sebastian Dröge (slomo) 2014-08-13 14:34:13 UTC 
Closing as this code is not reachable anyway if error is not NULL.