After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734640 - g-i: Don't include unistd.h in the repository test programs
g-i: Don't include unistd.h in the repository test programs
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-12 05:33 UTC by Fan, Chun-wei
Modified: 2015-02-07 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests.repository: Don;t include unistd.h (1.46 KB, patch)
2014-08-12 05:34 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2014-08-12 05:33:28 UTC 
Hi,

When working on the MSVC/distutils support for g-i, the source files in g-i's tests/repository all included unistd.h, which seem to me that those includes could be dropped, as:

-They are not universally available.
-Dropping their inclusion did not cause any build or
 run-time errors and warnings, and did not affect the
 results of the tests, even on Linux

So, perhaps we could drop those includes?
Comment 1 Fan, Chun-wei 2014-08-12 05:34:37 UTC 
Created attachment 283158 [details] [review]
tests.repository: Don;t include unistd.h

Hi,

Here comes the patch...

With blessings, thank you!
Comment 2 Colin Walters 2014-08-13 01:57:44 UTC 
Review of attachment 283158 [details] [review]:

Sure, I assume it was just a copy/paste thing.
Comment 3 Fan, Chun-wei 2014-08-13 06:22:30 UTC 
Review of attachment 283158 [details] [review]:

Hello Colin,

Thanks for the review, the patch was pushed as 6fc4a1f9d.

With blessings, thank you!
Comment 4 André Klapper 2015-02-07 16:51:54 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]