After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734620 - Use 'image' instead of 'child' for adding images to buttons
Use 'image' instead of 'child' for adding images to buttons
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-11 14:34 UTC by Debarshi Ray
Modified: 2014-08-13 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ensure that icon-only buttons get the 'image-button' style class (4.52 KB, patch)
2014-08-11 14:38 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-08-11 14:34:46 UTC 
Due to the way gtk_button_construct_child is written, when a Gtk.Image is added to a Gtk.Button via the 'child' property the button does not get the 'image-button' style class attached to it. We need to add it via the 'image' property for that to happen.
Comment 1 Debarshi Ray 2014-08-11 14:38:45 UTC 
Created attachment 283107 [details] [review]
Ensure that icon-only buttons get the 'image-button' style class
Comment 2 Debarshi Ray 2014-08-11 14:44:14 UTC 
As a result of this the previous and next buttons are smaller than before. They are still OK for touch, but I don't know what we prefer.
Comment 3 Debarshi Ray 2014-08-13 13:10:21 UTC 
Review of attachment 283107 [details] [review]:

I pushed this after talking to Lapo in #gnome-design on GIMPNet.