After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734618 - Allow drawing keys with invalid keycodes
Allow drawing keys with invalid keycodes
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Drawing
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2014-08-11 14:16 UTC by Antonio Ospite
Modified: 2016-01-21 20:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libgnomekbd/gkbd-keyboard-drawing.c: draw keys with invalid keycodes (1.60 KB, patch)
2014-08-11 14:16 UTC, Antonio Ospite
committed Details | Review

Description Antonio Ospite 2014-08-11 14:16:43 UTC
Created attachment 283105 [details] [review]
libgnomekbd/gkbd-keyboard-drawing.c: draw keys with invalid  keycodes

Some keys like the function key "FN" are described in geometry files but
they have no keycode associated to them. You can find such keys in the thinkpad and in the hhk geometry files.

Right now these keys are not drawn which at first made me think to an error in the geometry file I was hacking on, instead it was just gkbd-keyboard-drawing.c skipping keys with invalid keycodes.

Let's still draw the shapes of these keys with invalid keycodes anyway, and just skip looking for the labels as the label is derived from the keycode.
Comment 1 Antonio Ospite 2016-01-11 14:25:27 UTC
ping
Comment 2 Michael Catanzaro 2016-01-21 20:37:14 UTC
Looks sane, thank you!