GNOME Bugzilla – Bug 734610
Add a special background to use for performance testing
Last modified: 2014-08-18 14:56:28 UTC
Performance testing was producing inconsistent values at different times in the day since the GNOME default background is animated and sometimes has a single layer, and sometimes two blended layers. So we have consistent numbers, install a simple animated background with GNOME Shell that has 40-year long transition ending in 2030,a and set an environment variable in gnome-shell-perf-tool so that the background is override with that background. (The background depends on files installed by gnome-backgrounds; we assume that the person running performance tests is doing so within the scope of a full GNOME install.)
Created attachment 283092 [details] [review] Add a special background to use for performance testing
Review of attachment 283092 [details] [review]: ::: data/perf-background.xml.in @@ +5,3 @@ + we want to make sure that also performs well; for that reason we ship + an "animated" background that animates super-slowly to use during + performance tests; it will be in the blended state until 2030. --> That makes sense. I was about to ask "why not use a static image". ::: src/gnome-shell-perf-tool.in @@ +84,3 @@ + # A fixed background image + env['SHELL_BACKGROUND_IMAGE'] = '@pkgdatadir@/perf-background.xml' Shouldn't we unset this in restore_shell() ?
Pushed with fix to comment. Attachment 283092 [details] pushed as 20fc973 - Add a special background to use for performance testing
Review of attachment 283092 [details] [review]: ::: data/perf-background.xml.in @@ +5,3 @@ + we want to make sure that also performs well; for that reason we ship + an "animated" background that animates super-slowly to use during + performance tests; it will be in the blended state until 2030. --> Of course, this was meant to say 'for much of the day' not 'for much of the data' ::: src/gnome-shell-perf-tool.in @@ +84,3 @@ + # A fixed background image + env['SHELL_BACKGROUND_IMAGE'] = '@pkgdatadir@/perf-background.xml' No, the unset of MUTTER_WM_CLASS_FILTER shouldn't be there either - we only modify a copy of the environment, and pass that copy when we're exec'ing the shell process to run the tests.