After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734593 - The geoip module uses GeoIP-1.5.1 which has a broken .pc file
The geoip module uses GeoIP-1.5.1 which has a broken .pc file
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2014-08-10 22:27 UTC by Nicklas Lindgren
Modified: 2015-02-19 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core-deps-3.14: Upgrade geoip to 1.6.2 (1.07 KB, patch)
2014-08-10 22:37 UTC, Nicklas Lindgren
needs-work Details | Review
core-deps-3.16: update to geoip 1.6.4 (1.57 KB, patch)
2015-02-19 20:59 UTC, Michael Catanzaro
none Details | Review

Description Nicklas Lindgren 2014-08-10 22:27:25 UTC
I ran into this problem while running jhbuild for the module gnome-session, after having previously built gnome-terminal.
This was jhbuild revision 0d4bfb0 with some patches to module dependencies.

The GeoIP-1.5.1 build produces a geoip.pc-file that uses the variable exec_prefix without first defining it. This problem was fixed before the release of 1.5.2 (https://github.com/maxmind/geoip-api-c/commit/79624168b3d7d4136aa042bc5afb466ed4d5d9ee)

This causes problems for jhbuild, since it parses the output of `pkg-config --list-all` to find available system dependencies.

pkg-config 0.28 will terminate the output of --list-all early with an error message when it encounters geoip.pc:

    Variable 'exec_prefix' not defined in '/home/nili/jhbuild/install/lib/pkgconfig/geoip.pc'

This makes jhbuild fail to detect some packages.

It is possible to work around the build problem by using the 1.6.2 release for the geoip module, but i don't know if it works as a drop-in replacement for 1.5.1 for actual use.
Comment 1 Nicklas Lindgren 2014-08-10 22:37:49 UTC
Created attachment 283050 [details] [review]
core-deps-3.14: Upgrade geoip to 1.6.2
Comment 2 Michael Catanzaro 2015-02-19 20:55:35 UTC
Review of attachment 283050 [details] [review]:

So we should also remove the maxmind repo from the list at the top of the file. And there's no need to drop hash and size verification. I'll push something similar to this though, thanks.
Comment 3 Michael Catanzaro 2015-02-19 20:59:55 UTC
The following fix has been pushed:
1d70530 core-deps-3.16: update to geoip 1.6.4
Comment 4 Michael Catanzaro 2015-02-19 20:59:58 UTC
Created attachment 297333 [details] [review]
core-deps-3.16: update to geoip 1.6.4