After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734540 - audioencoder: Mark caps argument as not being transferred
audioencoder: Mark caps argument as not being transferred
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 12:18 UTC by Sebastian Rasmussen
Modified: 2014-08-10 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (862 bytes, patch)
2014-08-09 12:20 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 12:18:31 UTC 
Mistakes have been done elsewhere, which might have been avoided had the caps argument been properly annotated as being transfer none.
Comment 1 Sebastian Rasmussen 2014-08-09 12:20:18 UTC 
Created attachment 282995 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 09:49:28 UTC 
Thanks, I've pushed this now, but I might be more resistant if more patches like this pop up. transfer none is the default and there's no reason why anyone should have assumed otherwise:

commit a285f7126b0af08d59a8dc7a14461e1ea6a76706
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 14:14:48 2014 +0200

    audioencoder: Mark caps argument as not being transferred
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734540