After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734539 - element-maker: Avoid leaking copy of caps object
element-maker: Avoid leaking copy of caps object
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal trivial
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 12:03 UTC by Sebastian Rasmussen
Modified: 2014-08-11 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (967 bytes, patch)
2014-08-09 12:04 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 12:03:50 UTC 
gst_pad_get_pad_template_caps() returns a reference which is unreferenced, so
creating a copy using gst_caps_copy() results in a reference leak. The attached
patch removes the uncessary calls to gst_caps_copy().
Comment 1 Sebastian Rasmussen 2014-08-09 12:04:31 UTC 
Created attachment 282994 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 11:34:01 UTC 
commit 9e50a4b8eb6877c9b6ffc2db16b05c0825fd544b
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 13:27:00 2014 +0200

    element-maker: Avoid leaking copy of caps object
    
    gst_pad_get_pad_template_caps() returns a reference which is unreferenced,
    so creating a copy using gst_caps_copy() results in a reference leak.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734539