After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734529 - wildmidi: Avoid leaking copy of caps object
wildmidi: Avoid leaking copy of caps object
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 11:51 UTC by Sebastian Rasmussen
Modified: 2014-08-10 11:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.48 KB, patch)
2014-08-09 11:52 UTC, Sebastian Rasmussen 		rejected Details | Review

Description Sebastian Rasmussen 2014-08-09 11:51:55 UTC 
gst_pad_get_pad_template_caps() returns a reference which is unreferenced, so
creating a copy using gst_caps_copy() results in a reference leak. The attached
patch removes the uncessary calls to gst_caps_copy().
Comment 1 Sebastian Rasmussen 2014-08-09 11:52:45 UTC 
Created attachment 282985 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 11:01:02 UTC 
Neither timidity nor the sndfile source have been ported, and there's a sndfile chunk in your patch that you didn't mention..