After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734524 - wrappercamerabinsrc: Unref elements after usage
wrappercamerabinsrc: Unref elements after usage
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 11:46 UTC by Sebastian Rasmussen
Modified: 2014-08-11 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (2.30 KB, patch)
2014-08-09 11:46 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 11:46:07 UTC 
gst_bin_get_by_name() and gst_bin_get_by_interface() return reference to elements that need to be released after usage. The attached patch aims to fix this.
Comment 1 Sebastian Rasmussen 2014-08-09 11:46:27 UTC 
Created attachment 282981 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 14:31:03 UTC 
Pushed, thanks for the patch:

commit 5d1fedd18ef5587335afbc713ea54c9b9a835765
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 11:36:38 2014 +0200

    wrappercamerabinsrc: Unref elements after usage
    
    gst_bin_get_by_name() and gst_bin_get_by_interface() both return
    references to elements that need to be unreferenced after usage.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734524