After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734478 - shapewipe: Unref caps and element after usage
shapewipe: Unref caps and element after usage
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-08 10:56 UTC by Sebastian Rasmussen
Modified: 2014-08-11 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch fixing leaks. (1.93 KB, patch)
2014-08-08 10:57 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-08 10:56:41 UTC 
gst_pad_get_pad_template_caps() and gst_bin_get_by_name() both return reference to objects that need to be unreffed after usage. The attached patch aim to fix this.

__tim mentioned that shapewipe might no longer be maintained, but I still submit this patch to allow you to either take the fix on or set the bug as WONTFIX. This way I have done the best I can. :)
Comment 1 Sebastian Rasmussen 2014-08-08 10:57:27 UTC 
Created attachment 282898 [details] [review]
Proposed patch fixing leaks.
Comment 2 Tim-Philipp Müller 2014-08-10 10:14:03 UTC 
> __tim mentioned that shapewipe might no longer be maintained, but I still
> submit this patch to allow you to either take the fix on or set the bug as
> WONTFIX. This way I have done the best I can. :)

Erm, this is not what I said at all. I said I didn't know if the shapewipe example had been ported to 1.0 or not. You could just check yourself whether those plugins/examples have been ported before submitting bugs...

commit 70a43758bbce5b2fe07df8c7b40c13b1ebd31ea1
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Fri Aug 8 12:54:30 2014 +0200

    shapewipe: Unref caps and element after usage
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734478