After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734477 - smokeenc: Unref pad template caps after usage
smokeenc: Unref pad template caps after usage
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal minor
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-08 10:51 UTC by Sebastian Rasmussen
Modified: 2014-08-10 10:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch fixing leak. (759 bytes, patch)
2014-08-08 10:52 UTC, Sebastian Rasmussen
rejected Details | Review

Description Sebastian Rasmussen 2014-08-08 10:51:34 UTC
gst_pad_get_pad_template_caps() returns a caps reference that needs to be unreffed after usage. The attached patch fixes this.

__tim mentioned that this element might no longer be maintained. I submit the patch so you can decide to taking it on or setting it as WONTFIX (in case the element is unmaintained).
Comment 1 Sebastian Rasmussen 2014-08-08 10:52:22 UTC
Created attachment 282897 [details] [review]
Proposed patch fixing leak.
Comment 2 Tim-Philipp Müller 2014-08-10 10:07:12 UTC
They have not been ported from the look of it.