After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734456 - src/spinner/Makefile.am: missing \ at end of lines breaks jhbuild
src/spinner/Makefile.am: missing \ at end of lines breaks jhbuild
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2014-08-07 21:23 UTC by Pietro Gagliardi (andlabs)
Modified: 2014-08-08 06:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix bug (1.77 KB, patch)
2014-08-07 21:23 UTC, Pietro Gagliardi (andlabs)
committed Details | Review

Description Pietro Gagliardi (andlabs) 2014-08-07 21:23:01 UTC
Created attachment 282847 [details] [review]
patch to fix bug

When building adwaita-icon-themes with jhbuild (master; on Ubuntu 14.04), the build fails with

make[2]: Entering directory `/home/pietro/jhbuild/checkout/adwaita-icon-theme/src/spinner'
for file in ; do \
                size='scalable-up-to-32'
/bin/bash: -c: line 2: syntax error: unexpected end of file
make[2]: *** [render-png] Error 1
make[2]: git.mk: Generating .gitignore
*** Waiting for unfinished jobs....
make[2]: Leaving directory `/home/pietro/jhbuild/checkout/adwaita-icon-theme/src/spinner'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/pietro/jhbuild/checkout/adwaita-icon-theme/src'
make: *** [all-recursive] Error 1
*** Error during phase build of adwaita-icon-theme: ########## Error running make -j 3 *** [29/29]

The problem is obvious: a line (actually two) of the Makefile.am is/are missing \ at the end.

The attached patch will fix the issue. Thanks.