GNOME Bugzilla – Bug 734451
gst_ffmpegmux_base_init should sanitize the names too
Last modified: 2016-01-07 17:26:26 UTC
Created attachment 282840 [details] [review] patch implementing the change (mostly a copy-paste) gst_ffmpegdemux_base_init replaces dots/comas in format name by underscore. gst_ffmpegmux_base_init should do that too. I hope the attached patch doesn't break anything - doesn't look like it should, but I could have missed something.
Review of attachment 282840 [details] [review]: ::: ext/libav/gstavmux.c @@ +211,3 @@ + p++; + } + It would be better to have this in a function that could be used in both elements or move it into gst_ffmpeg_formatid_to_caps when it uses the fallback caps.
(In reply to comment #1) > > It would be better to have this in a function that could be used in both > elements or move it into gst_ffmpeg_formatid_to_caps when it uses the fallback > caps. Probably more of the former, as that loop is used in gst_ffmpeg{,de}mux_register too.
Can you update the patch?
This should take care of it hopefully: commit 83ce87e7c815e5f78bb72b52c5739d75c4a85b72 Author: Tim-Philipp Müller <tim@centricular.com> Date: Thu Jan 7 17:13:29 2016 +0000 av: canonicalise av plugin name more consistently in more places Use g_strdelimit(), make sure to include comma as well, which isn't included in G_STR_DELIMITERS. https://bugzilla.gnome.org/show_bug.cgi?id=734451