After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734451 - gst_ffmpegmux_base_init should sanitize the names too
gst_ffmpegmux_base_init should sanitize the names too
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
1.4.0
Other Linux
: Normal minor
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-07 19:36 UTC by Rafał Mużyło
Modified: 2016-01-07 17:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch implementing the change (mostly a copy-paste) (2.41 KB, patch)
2014-08-07 19:36 UTC, Rafał Mużyło
needs-work Details | Review

Description Rafał Mużyło 2014-08-07 19:36:37 UTC
Created attachment 282840 [details] [review]
patch implementing the change (mostly a copy-paste)

gst_ffmpegdemux_base_init replaces dots/comas in format name by underscore.
gst_ffmpegmux_base_init should do that too.

I hope the attached patch doesn't break anything - doesn't look like it should, but I could have missed something.
Comment 1 Thiago Sousa Santos 2014-08-08 19:58:25 UTC
Review of attachment 282840 [details] [review]:

::: ext/libav/gstavmux.c
@@ +211,3 @@
+    p++;
+  }
+

It would be better to have this in a function that could be used in both elements or move it into gst_ffmpeg_formatid_to_caps when it uses the fallback caps.
Comment 2 Rafał Mużyło 2014-08-08 20:25:34 UTC
(In reply to comment #1)
> 
> It would be better to have this in a function that could be used in both
> elements or move it into gst_ffmpeg_formatid_to_caps when it uses the fallback
> caps.

Probably more of the former, as that loop is used in gst_ffmpeg{,de}mux_register too.
Comment 3 Sebastian Dröge (slomo) 2014-08-13 15:21:49 UTC
Can you update the patch?
Comment 4 Tim-Philipp Müller 2016-01-07 17:26:26 UTC
This should take care of it hopefully:

commit 83ce87e7c815e5f78bb72b52c5739d75c4a85b72
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Thu Jan 7 17:13:29 2016 +0000

    av: canonicalise av plugin name more consistently in more places
    
    Use g_strdelimit(), make sure to include comma as well, which
    isn't included in G_STR_DELIMITERS.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734451