After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734446 - network: Make broken configuration entries red
network: Make broken configuration entries red
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-07 16:41 UTC by Bastien Nocera
Modified: 2014-08-08 10:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Make broken configuration entries red (22.33 KB, patch)
2014-08-07 16:41 UTC, Bastien Nocera 		needs-work Details | Review
network: Make broken configuration entries red (25.22 KB, patch)
2014-08-08 09:32 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-08-07 16:41:44 UTC 
.
Comment 1 Bastien Nocera 2014-08-07 16:41:48 UTC 
Created attachment 282837 [details] [review]
network: Make broken configuration entries red

When a configuration setting is wrong, set the entry or file chooser
that contains the incorrect information to be surrounded by red.

This makes it easier for users to find where the error was made that
disallows them to click the "Apply" button.
Comment 2 Rui Matos 2014-08-08 09:17:54 UTC 
Review of attachment 282837 [details] [review]:

You forgot to add the ui-helpers files
Comment 3 Bastien Nocera 2014-08-08 09:32:41 UTC 
Created attachment 282888 [details] [review]
network: Make broken configuration entries red

When a configuration setting is wrong, set the entry or file chooser
that contains the incorrect information to be surrounded by red.

This makes it easier for users to find where the error was made that
disallows them to click the "Apply" button.
Comment 4 Rui Matos 2014-08-08 09:57:32 UTC 
Review of attachment 282888 [details] [review]:

Otherwise looks fine

::: panels/network/wireless-security/ws-leap.c
@@ +67,3 @@
 		return FALSE;
+	}
+	widget_set_error (entry);

unset
Comment 5 Bastien Nocera 2014-08-08 10:10:36 UTC 
Attachment 282888 [details] pushed as 62db29b - network: Make broken configuration entries red