After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734398 - Missing high contrast icon
Missing high contrast icon
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-07 07:16 UTC by Andreas Nilsson
Modified: 2014-08-13 19:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot under GNOME Continuous (943.97 KB, image/png)
2014-08-07 07:16 UTC, Andreas Nilsson 		  Details
gnome-photos highcontrast icons (10.96 KB, application/gzip)
2014-08-07 08:07 UTC, Andreas Nilsson 		  Details
Missing high contrast icons (27.46 KB, patch)
2014-08-12 11:37 UTC, Pranav Kant 		needs-work Details | Review
icons: Rename the hicolor source to make room for HighContrast icons (1.21 MB, patch)
2014-08-13 11:22 UTC, Debarshi Ray 		committed Details | Review
icons: Added HighContrast icons (19.00 KB, patch)
2014-08-13 16:10 UTC, Pranav Kant 		committed Details | Review

Description Andreas Nilsson 2014-08-07 07:16:26 UTC 
Created attachment 282753 [details]
screenshot under GNOME Continuous

As per http://wiki.gnome.org/GnomeGoals/HighContrastAppIcons

Will fix up with some graphics for this.
Comment 1 Andreas Nilsson 2014-08-07 08:07:30 UTC 
Created attachment 282755 [details]
gnome-photos highcontrast icons

These should be installed in a similar manner to the hicolor icons.
The gnome-photos.svg should be treated as a source, and not be installed.
Comment 2 Debarshi Ray 2014-08-07 08:23:43 UTC 
The high contrast icons for Boxes, Clocks, Documents and a bunch of other applications are installed by gnome-themes-standard. What is the plan? Should the high contrast theme continue to own them, or should the applications own them now?
Comment 3 Debarshi Ray 2014-08-07 08:24:13 UTC 
Oh, I forgot. Thanks for creating the icon, Andreas!
Comment 4 Pranav Kant 2014-08-12 11:37:15 UTC 
Created attachment 283175 [details] [review]
Missing high contrast icons
Comment 5 Debarshi Ray 2014-08-13 11:13:05 UTC 
Review of attachment 283175 [details] [review]:

::: data/icons/Makefile.am
@@ +1,1 @@
+SUBDIRS = hicolor HighContrast

We don't need to create separate directories. Just naming the icons as <theme>_<context>_<size>_gnome-photos.png is enough because the Makefile.am already works that way.

We should rename the hicolor SVG source as highcolor_gnome-photos.png so that we can also have the HighContrast SVG in the same directory.
Comment 6 Debarshi Ray 2014-08-13 11:22:12 UTC 
Created attachment 283274 [details] [review]
icons: Rename the hicolor source to make room for HighContrast icons
Comment 7 Pranav Kant 2014-08-13 16:10:38 UTC 
Created attachment 283312 [details] [review]
icons: Added HighContrast icons
Comment 8 Debarshi Ray 2014-08-13 19:49:24 UTC 
Review of attachment 283312 [details] [review]:

Perfect.
Comment 9 Debarshi Ray 2014-08-13 19:53:17 UTC 
Thanks for the icons, Andreas!