After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734392 - dvbsrc: tuning block in playing state
dvbsrc: tuning block in playing state
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-07 02:17 UTC by jingbo.hou
Modified: 2018-11-03 13:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
prevent tuning in blocking (4.21 KB, patch)
2014-08-09 02:36 UTC, jingbo.hou
none Details | Review

Description jingbo.hou 2014-08-07 02:17:20 UTC
when failure to tune in playing state ,  task can't read data from dvr node and will be in a infinite loop.  now tuning again,  we will be in blocking.
Comment 1 Reynaldo H. Verdejo Pinochet 2014-08-08 00:36:41 UTC
Hello, thanks for reporting.

Are you listening to the tuning-fail signal? Acting on it
should help you temporarily overcome this situation.

Anyhow, I reproduced this with gst-validate's new emit-signal
(for tune) and confirmed. Looking at the code, the re-tuning
error path in dvbsrc is indeed flawed. Will work on a fix.
Comment 2 Reynaldo H. Verdejo Pinochet 2014-08-08 00:47:19 UTC
For what is worth though, even if we fix this particular
bug on dvbsrc there's still work to be done for the retuning
in playing state use case to work properly (on dvbsrc and
beyond). That should be discussed in another (enhancement)
bug though, if there's not one already(?).
Comment 3 Reynaldo H. Verdejo Pinochet 2014-08-08 01:03:04 UTC
(In reply to comment #1)
> [...]
> Anyhow, I reproduced this with gst-validate's new emit-signal
> (for tune) and confirmed. Looking at the code, the re-tuning
> error path in dvbsrc is indeed flawed. Will work on a fix.

lol, adding insult to injury, I haven't even pushed the new
"tune" signal patch (pending some further investigation) so in
the above comment, please interpret is as if I was referring
to the "tune" property been set while playing, I guess that's
what you did.
Comment 4 jingbo.hou 2014-08-09 02:18:34 UTC
(In reply to comment #2)
> For what is worth though, even if we fix this particular
> bug on dvbsrc there's still work to be done for the retuning
> in playing state use case to work properly (on dvbsrc and
> beyond). That should be discussed in another (enhancement)
> bug though, if there's not one already(?).

if fix this bug, and we will provide a more perfect method that can be used anytime and anywhere when you want to tune.  As i know changing state will spend much time. but it is not necessary sometimes, example scanning frequencies and fine tuning. they need frequent tuning and use the less time the better
Comment 5 jingbo.hou 2014-08-09 02:36:07 UTC
Created attachment 282956 [details] [review]
prevent tuning in blocking

dvbsrc:Prevent from tuning blocked in playing state.
Comment 6 jingbo.hou 2014-08-09 02:39:09 UTC
(In reply to comment #3)
> lol, adding insult to injury, I haven't even pushed the new
> "tune" signal patch (pending some further investigation) so in
> the above comment, please interpret is as if I was referring
> to the "tune" property been set while playing, I guess that's
> what you did.

what scruple does prevent pushing your new "tune" signal patch ?
But i think , if we decide retuning and perpare set "tune" property, from then on , all data reading from dvr are not needful. if so , the task of reading data should stop until finish tuning. i pushed a new patch for this issue.
Comment 7 jingbo.hou 2014-08-11 01:54:12 UTC
If no dvb signal suddenly in playing state,   the task will be in a infinite loop also, and can 't  automatically exit this reading .  i think the reading task should automatically exit the loop when an accident happens. and also we should be add more code to check up real-time all dvb signal state .
Comment 8 GStreamer system administrator 2018-11-03 13:25:57 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/168.