GNOME Bugzilla – Bug 734381
Remove encoding preference from preferences dialog
Last modified: 2016-01-15 16:54:41 UTC
How about removing the ability to change the default page encoding from the preferences dialog?
Created attachment 282740 [details] [review] Remove encoding preference from preferences dialog I can't see any benefit to this setting, besides to confuse and break pages. This patch does not remove the encodings dialog that allows changing the encoding on the current page, and it doesn't remove encodings from the window menu. We should consider these as well. Users don't need to know anything about encodings and Firefox doesn't allow changing encoding at all anymore.
Created attachment 282746 [details] [review] Remove encoding preference from preferences dialog I can't see any benefit to this setting, besides to confuse and break pages. This patch does not remove the encodings dialog that allows changing the encoding on the current page, and it doesn't remove encodings from the window menu. We should consider these as well. Users don't need to know anything about encodings and Firefox doesn't allow changing encoding at all anymore.
We've discovered that Firefox does allow changing the default encoding (Preferences -> Content -> Fonts and Colors -> Advanced) but does not allow overriding the encoding on a per-page basis. I don't think that means we need this setting, though.
(In reply to comment #3) > We've discovered that Firefox does allow changing the default encoding > (Preferences -> Content -> Fonts and Colors -> Advanced) but does not allow > overriding the encoding on a per-page basis. I don't think that means we need > this setting, though. I use it sometimes on Gnome changelogs, for example http://ftp.gnome.org/pub/gnome/sources/epiphany/3.12/epiphany-3.12.1.changes . It's served in the wrong encoding (try looking up Matej Urbančič in that changelog).
Hm, I hadn't considered non-HTML documents... maybe we should default to UTF-8 for these, or see how gedit detects the document's encoding.... Interestingly enough, Firefox gets it wrong too.
Let's discuss that further in bug #735559 and leave this bug solely for the preferences dialog option.
Still want to push this. We should not allow changing the _default_ encoding since that breaks the web. If individual documents are broken, the existing encoding menu can be used on a per-document basis.
Pinging reviewers
Ping reviewers again. We seem to all agree that this setting should never be changed. There is only some concern as to the proper default, which is a WebKit issue.
Comment on attachment 282746 [details] [review] Remove encoding preference from preferences dialog Ok, we can always bring it back if needed.