After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734366 - gcr: fix UI code to remove X11 specific dependencies
gcr: fix UI code to remove X11 specific dependencies
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
3.12.x
Other Mac OS
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-06 15:25 UTC by David Evans
Modified: 2021-02-16 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David Evans 2014-08-06 15:25:23 UTC 
The current UI code uses X11 specific function calls and relies on gdk/gdkx.h in several places.  This breaks the build when gtk+ is built with other than the X11 backend.  Specifically this makes it impossible to build gcr and its dependents using the gtk+ Quartz backend on Mac OS X.

Requesting a rework of this code to use only backend agnositic gtk+ APIs if at all possible or at least allow building with the gtk+ Quartz backend.

See also https://trac.macports.org/ticket/41839.

Thanks for any help
Dave Evans
GNOME maintainer for MacPorts
Comment 1 Stef Walter 2014-08-06 15:45:29 UTC 
I would certainly review and accept patches to make these dependencies conditional.
Comment 2 David Evans 2014-08-06 17:50:17 UTC 
Fair enough.  Will take a look at what is involved and let you know.  As a starting point, is there anything in the code to your knowledge that really requires X11 specific code (i.e. can't be done otherwise)?  Is it fair to utilize features that are only available in gtk 3.12+?
Comment 3 Stef Walter 2014-08-06 18:52:02 UTC 
I think it's just places where we turn window handles/ids into strings where we currently have an X dependency. This would need to be done in a platform specific manner for each GDK backend.

Bumping the gtk dependency to 3.10 or 3.12 isn't bad, if it proves to be necessary.
Comment 4 Ignat Loskutov 2016-08-28 20:03:06 UTC 
This also prevents wayland systems from eliminating the X11 dependency at all. Is X11 still necessary for gcr?
Comment 5 Stef Walter 2016-08-31 13:10:18 UTC 
See above comments. Patches are welcome to make these dependencies optional, and identify non X11 windows appropriately.
Comment 6 Niels De Graef 2021-02-16 10:36:43 UTC 
This has been implemented for Wayland in the latest upstream, so there is no longer a hard X11 dependency.

Given that this issue hasn't seen any progress related to Quartz, I'm closing it now. If there's still a need to get this working, feel free to make an issue on the gcr GitLab repository, or an MR with the accompanying changes.