After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734350 - oggdemux: Unref peer pad after use in error case
oggdemux: Unref peer pad after use in error case
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-06 11:40 UTC by Sebastian Rasmussen
Modified: 2014-08-06 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch unreffing peer pad after use (866 bytes, patch)
2014-08-06 11:42 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-06 11:40:42 UTC 
While looking for accidentally forgotten unrefs after calling gst_pad_get_peer() I found such an occurance in gst_ogg_demux_check_duration_push(). The attached patch aims to fix this.
Comment 1 Sebastian Rasmussen 2014-08-06 11:42:42 UTC 
Created attachment 282659 [details] [review]
Proposed patch unreffing peer pad after use
Comment 2 Sebastian Dröge (slomo) 2014-08-06 11:48:59 UTC 
commit 1da3df79cfed5292299efa93f36c7a9c919af527
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Wed Aug 6 13:22:56 2014 +0200

    oggdemux: Unref peer pad after use in error case
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734350