After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734345 - tests: Add missing unrefs of objects after use
tests: Add missing unrefs of objects after use
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-06 10:41 UTC by Sebastian Rasmussen
Modified: 2014-08-06 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch plugging reference leaks. (2.72 KB, patch)
2014-08-06 10:44 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-06 10:41:08 UTC 
By looking for calls to functions that are annotated (transfer full) I noticed several occurances in the tests where the returned object was never unreffed. The attached patch aims to fix this.
Comment 1 Sebastian Rasmussen 2014-08-06 10:44:54 UTC 
Created attachment 282651 [details] [review]
Proposed patch plugging reference leaks.
Comment 2 Sebastian Dröge (slomo) 2014-08-06 11:47:49 UTC 
commit 4cf6a6e086572ae1debf865f8fc645e10737b7be
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Wed Aug 6 12:34:42 2014 +0200

    tests: Add missing unrefs of objects after use
    
    Unreffing the objects returned by gst_bin_get_by_name() and
    gst_pipeline_get_use() were missing in several tests, so add these.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734345