After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734303 - [warning] removing files outside of rygel
[warning] removing files outside of rygel
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
0.20.x
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-05 17:13 UTC by orbisvicis
Modified: 2014-09-10 21:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media-export: Don't delete file from fs event (2.94 KB, patch)
2014-08-24 07:32 UTC, Jens Georg
committed Details | Review

Description orbisvicis 2014-08-05 17:13:01 UTC
Reproduce:
1] Delete files shared by rygel, without using rygel (ie, locally).

Details:
Aug 05 12:45:06 ... rygel[7835]: (rygel:7835): MediaExport-WARNING **: Failed to remove file /storage/TEMP.FILMS/0a009d48-2003-463c-98c6-29700c38c46d-big_buck_bunny_720p_h264.mov: Error removing file: No such file or directory
Aug 05 12:45:06 ... rygel[7835]: (rygel:7835): MediaExport-WARNING **: Failed to remove file /storage/TEMP.FILMS/587fbb07-7962-41e6-9756-704d3ae2cff3-custom_title_test_big_buck_bunny_720p_h264.mov: Error removing file: No such file or directory

Version:
Rygel.x86_64 0.20.3-1.fc20
Comment 1 Jens Georg 2014-08-24 07:32:34 UTC
Created attachment 284330 [details] [review]
media-export: Don't delete file from fs event

If a file is removed by the user, then don't try to remove the file
again. There are some tools that move by remove & copy and Rygel will
then remove the just copied file.

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 2 Konstantin Svist 2014-08-26 07:15:39 UTC
Tried applying against 0.23.3 and 0.23.3.1, getting an error while compiling

make[4]: Entering directory `/raid/home/kostya/packages/rygel-0.23.3.1/src/plugins/media-export'
  VALAC    librygel_media_export_la_vala.stamp
error: Package `gupnp-av-1.0' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `gupnp-dlna-2.0' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `gupnp-dlna-gst-2.0' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `gupnp-av-1.0' not found in specified Vala API directories or GObject-Introspection GIR directories
Compilation failed: 4 error(s), 0 warning(s)
make[4]: *** [librygel_media_export_la_vala.stamp] Error 1
make[4]: Leaving directory `/raid/home/kostya/packages/rygel-0.23.3.1/src/plugins/media-export'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/raid/home/kostya/packages/rygel-0.23.3.1/src/plugins'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/raid/home/kostya/packages/rygel-0.23.3.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/raid/home/kostya/packages/rygel-0.23.3.1'
make: *** [all] Error 2
Comment 3 Jens Georg 2014-08-26 08:04:06 UTC
Huh? Patch was written against 0.23.3.1. is your build picking up the right vala?
Comment 4 Konstantin Svist 2014-08-26 16:25:59 UTC
$ vala --version
Vala 0.22.1
$ rpm -q vala
vala-0.22.1-1.fc20.x86_64

is what I have
Comment 5 Konstantin Svist 2014-08-28 00:47:24 UTC
*ping*
What should I do to make it work?
Comment 6 Jens Georg 2014-08-28 06:56:56 UTC
You do have the vapi files installed?
Comment 7 Konstantin Svist 2014-08-29 18:56:05 UTC
No idea...
I have /usr/share/vala-0.22/vapi/ dir with a bunch of .vapi files, is that it?
Comment 8 Konstantin Svist 2014-09-02 20:08:25 UTC
What should I try next?
Comment 9 Jens Georg 2014-09-10 21:07:02 UTC
Attachment 284330 [details] pushed as 75d644a - media-export: Don't delete file from fs event