After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734302 - [segfault] upload interrupted
[segfault] upload interrupted
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
git master
Other Linux
: Normal critical
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-05 17:03 UTC by orbisvicis
Modified: 2014-08-10 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
systemd backtrace (50.54 KB, text/plain)
2014-08-05 17:03 UTC, orbisvicis 		  Details
Valgrind log (1.48 MB, text/plain)
2014-08-09 19:03 UTC, Jens Georg 		  Details
server: Fix crash when import is cancelled (1.49 KB, patch)
2014-08-10 09:51 UTC, Jens Georg 		committed Details | Review

Description orbisvicis 2014-08-05 17:03:04 UTC 
Created attachment 282590 [details]
systemd backtrace

Reproduce:
1] Upload file [big_buck_bunny_720p_h264.mov] to 0/Filesystem/TEMP.FILMS (MediaExport URI filesystem folder) via gupnp-upload.
2] Abort transfer


Notes:
The uploaded file may have been harvested by rygel before the transfer was interrupted.

Version:
Rygel.x86_64 0.20.3-1.fc20
Comment 1 Jens Georg 2014-08-05 18:41:45 UTC 
ew. That looks ugly. What is the GUPnP version?
Comment 2 orbisvicis 2014-08-05 20:21:46 UTC 
gupnp.x86_64                   0.20.12-1.fc20
gupnp-av.x86_64                0.12.6-1.fc20
gupnp-dlna.x86_64              0.10.2-2.fc20
Comment 3 Jens Georg 2014-08-09 19:03:10 UTC 
Created attachment 283020 [details]
Valgrind log
Comment 4 Jens Georg 2014-08-10 09:03:44 UTC 
The offending code was added handling "host not found" scenarios during UPnP test.

In that case, libsoup does send message-finished signal directly and the action is still valid.

In the "upload cancelled" use-case, we already destroyed the action in "got-headers" signal handler and then try to access it again in message-finished.
Comment 5 Jens Georg 2014-08-10 09:51:58 UTC 
Created attachment 283028 [details] [review]
server: Fix crash when import is cancelled

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 6 Jens Georg 2014-08-10 09:52:29 UTC 
Attachment 283028 [details] pushed as 6e90efe - server: Fix crash when import is cancelled