After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734268 - Port to vte-2.91
Port to vte-2.91
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: terminal
git master
Other All
: Normal normal
: ---
Assigned To: Naba Kumar
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-05 09:59 UTC by Debarshi Ray
Modified: 2014-08-18 19:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
terminal: Silence -Wunused-function (1.19 KB, patch)
2014-08-05 10:05 UTC, Debarshi Ray
committed Details | Review
terminal: Fix incompatible pointer type warning (1017 bytes, patch)
2014-08-05 10:05 UTC, Debarshi Ray
committed Details | Review
terminal: Port to vte-2.91 (5.77 KB, patch)
2014-08-05 10:06 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2014-08-05 09:59:49 UTC
Current vte master has some API changes, and gnome-terminal does not have the word-chars key anymore. Lets adjust accordingly.
Comment 1 Debarshi Ray 2014-08-05 10:03:47 UTC
Bug 727743 has the details on word-chars removal.
Comment 2 Debarshi Ray 2014-08-05 10:05:21 UTC
Created attachment 282537 [details] [review]
terminal: Silence -Wunused-function
Comment 3 Debarshi Ray 2014-08-05 10:05:56 UTC
Created attachment 282538 [details] [review]
terminal: Fix incompatible pointer type warning
Comment 4 Debarshi Ray 2014-08-05 10:06:18 UTC
Created attachment 282539 [details] [review]
terminal: Port to vte-2.91
Comment 5 Sébastien Granjoux 2014-08-05 19:24:52 UTC
Review of attachment 282537 [details] [review]:

Thanks for your patch, I have just committed it.
Comment 6 Sébastien Granjoux 2014-08-05 19:25:04 UTC
Review of attachment 282538 [details] [review]:

Thanks for your patch, I have just committed it.
Comment 7 Sébastien Granjoux 2014-08-05 19:32:45 UTC
Review of attachment 282539 [details] [review]:

Thank for this patch too. It looks fine but could you use vte-2.90 if vte-2.91 is missing?
Comment 8 Sébastien Granjoux 2014-08-18 19:52:08 UTC
Review of attachment 282539 [details] [review]:

Thank for patch, I have just committed it after improving the configure script to still be able to compile with vte 2.90.