GNOME Bugzilla – Bug 734266
vp8dec: fails when input format changes
Last modified: 2014-09-02 06:14:17 UTC
Codec prints this error ERROR:gstvp8dec.c:432:open_codec: assertion failed: (dec->output_state == NULL) The problem is that output_state is not reset when format is changed. Attached is a patch that solves this issue.
Created attachment 282509 [details] [review] vp8dec: Reset output and input states when changing format
Thanks for the patch! It has been pushed to master along with a new unit test to prevent it from happening again and also applying the same fix for vp9dec that was actually crashing instead of asserting. commit 8bee49c85e51bc35123c6a4700e489441038dcf2 Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Tue Sep 2 00:55:17 2014 -0300 vp9dec: Fix segfault when a new caps is received Remember to unref the output caps when a new caps event is received as it should generate a new one based on the new caps. https://bugzilla.gnome.org/show_bug.cgi?id=734266 commit 0430ea87a3ab0767ca85fbbc27d1f68b41b73153 Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Tue Sep 2 00:54:35 2014 -0300 tests: vp8dec: add test for caps renegotiation Check that vp8dec can properly accept a new caps when upstream changes it https://bugzilla.gnome.org/show_bug.cgi?id=734266 commit f22b91dad52ae609f76cfda1b9ad6b064722273a Author: Jose Antonio Santos Cadenas <santoscadenas@gmail.com> Date: Tue Aug 5 10:34:39 2014 +0200 vp8dec: Reset output and input states when changing format https://bugzilla.gnome.org/show_bug.cgi?id=734266
Related bug #719359