After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734194 - afp volumes disconnect frequently
afp volumes disconnect frequently
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afp backend
1.21.x
Other Linux
: Normal major
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-03 10:00 UTC by Ross Lagerwall
Modified: 2014-08-03 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
afp: Try to prevent idle disconnects (2.58 KB, patch)
2014-08-03 10:06 UTC, Ross Lagerwall 		committed Details | Review

Description Ross Lagerwall 2014-08-03 10:00:47 UTC 
When connected to an OS X 10.8 AFP volume, I get disconnected after only a few minutes of inactivity, even though the AFP server is set not to disconnect users.

Combined with bug 710490, this is pretty annoying.

A wiretrace shows that, for whatever reason, the server sends Tickle messages less and less frequently (even though the client responds to them promptly) until after 128 seconds of inactivity, the server disconnects.
Comment 1 Ross Lagerwall 2014-08-03 10:06:22 UTC 
Created attachment 282404 [details] [review]
afp: Try to prevent idle disconnects

Some servers (e.g. OS X 10.8) disconnect clients who don't respond to
server notifications.  Prevent this by sending FPGetVolParms, as the
spec suggests.
Comment 2 Ross Lagerwall 2014-08-03 11:21:27 UTC 
The attached patch fixes the problem for me.
Comment 3 Carl-Anton Ingmarsson 2014-08-03 13:04:27 UTC 
Review of attachment 282404 [details] [review]:

::: daemon/gvfsafpvolume.c
@@ +62,1 @@
   /* TODO: Add deinitalization code here */

You can remove this TODO.
Comment 4 Ross Lagerwall 2014-08-03 16:13:23 UTC 
(In reply to comment #3)
> Review of attachment 282404 [details] [review]:
> 
> ::: daemon/gvfsafpvolume.c
> @@ +62,1 @@
>    /* TODO: Add deinitalization code here */
> 
> You can remove this TODO.

Done. Pushed to master as a4016460538ea8be22aa0d8289922b389a93ef78. Thanks for the review!