GNOME Bugzilla – Bug 734193
on upload, set 'upload date' to 'taken date'
Last modified: 2014-10-25 17:23:42 UTC
.
I don't understand: do you mean to add that as an option to frogr or making the change for every single case? I personally like to differentiate between upload and taken date, because they are different things, so in any case I'd rather go for adding it as an option, but perhaps I'm missing something. In any case, I don't think it's possible to do this at the same time we are uploading a picture, I guess it probably would mean an extra API call to flickr.photos.setDates()[1] (which I don't have any problem with, other than it would slightly delay the upload of each picture). [1] https://www.flickr.com/services/api/flickr.photos.setDates.html
Ah, indeed, what a poorly written report... I wonder who wrote it! I try to elaborate on what the original author possibly meant :) Personally I don't care much about the upload date, and I would rather see my stream ordered by take date. Currently I need to use third party tools to reset the 'upload date'. So I'd like to have an option (like a check box) to set the 'uplaod date' to the 'taken date'. (yep, that's probably another API call, after the upload API)
Thanks for the clarification. I already added the implementation for that API call internally in src/flicksoup[1], so now it's a matter of using that new functionality from frogr to instruct it to set the posted date to the upload date, and the UI changes associated to that change. Unfortunately, I can only work on this in 'chunks' of spare time, so I can't promise on when it will be ready, other than "I'll do my best" to get it finished as soon as possible :/ But that feature will definitely be included in the next release, you can be sure of that! :) [1] https://git.gnome.org/browse/frogr/commit/?id=81337080343fe796e607cee8b962aafbd02d4e0a
More commits, this is almost implemented now :): https://git.gnome.org/browse/frogr/commit/?id=ce693c1a23843aff982fe9f6c9100f73f55eef10 https://git.gnome.org/browse/frogr/commit/?id=17c6da666695915a748523c0bb45f5f9dede8f8a https://git.gnome.org/browse/frogr/commit/?id=9758fe11d17cb25e36e80d75d0e37e2061802336 Still, this is not 100% correct yet since the current code assumes EXIF information stores date and time in UTC, but I pushed it anyway because this information is only used if this new (optional) setting is enabled, so we can fix it later.
thanks! no hurry ;)
In the end, I settled with the UTC thing since, after checking the different options, I don't think there's a much better option. See a more detailed comment in this commit: https://git.gnome.org/browse/frogr/commit/?id=ca585b53e477911ea9f600d24a9cf63c1da19d16 Anyway, if you want it to get pictures in the photostream (which I guess is what nearly anyone enabling that option would be interested in), using that date as UTC should cause the same effect, and 'Date Taken' so I think it should be fine. Thus, I'm now resolving this bug as FIXED although I can't guarantee I will able to do a new release yet, so if you want to download the code from the git repository and try it yourself, I'd appreciate any feedback :) Hope it works fine for you. I believe this is a useful feature that I will end using myself too, so thanks for the idea!
in src/frogr-settings-dialog.c:_("Set 'Taken Date' as 'Posted Date' for Pictures"), it is "Set 'Posted Date' as 'Taken Date' for Pictures" not..."Set 'Taken Date' as 'Posted Date' for Pictures" hoping it's just a label issue, not a logic one
I did a try. It seems it has no effect. > static void _set_date_taken_as_posted_for_picture () sounds very wrong. To clarify: - DATE TAKEN, is the EXIF value, when the photo was taken. This should never be changed. - DATE POSTED, is when the photo was uploaded to flickr. Flickr uses this value to order the photo stream. - if you want your photo stream in the same order as you took the photos, you need to change the DATE POSTED, and set it with the value of the DATE TAKEN.
(In reply to comment #8) > I did a try. It seems it has no effect. actually it seems it had some effect, when the setting was... unchecked. Apparently, [x] Set 'Taken Date' as 'Posted Date' for Pictures --> does nothing [ ] Set 'Taken Date' as 'Posted Date' for Pictures --> set 'posted date' as 'taken date'
not sure anymore. Now it seems it worked correctly (with setting checked, it reset the upload date). Maybe some side effect at some point?
(In reply to comment #7) > in > src/frogr-settings-dialog.c:_("Set 'Taken Date' as 'Posted Date' for > Pictures"), > > it is "Set 'Posted Date' as 'Taken Date' for Pictures" > not..."Set 'Taken Date' as 'Posted Date' for Pictures" > > hoping it's just a label issue, not a logic one Hmmm... I don't think the label is wrong. What I meant was "use the value of 'date taken' and use it to set the value of 'date posted'", not the other way around. It might be a problem with the wording (as a non-native English speaker I do make quite some mistakes) but in my mind "Set 'Taken Date' _AS_ 'Posted Date'" means what I explained above. Perhaps it's different if we say "set 'upload date' _TO_ 'taken date'", as you wrote this bug's title? In my mind, changing "AS" for "TO" actually causes the sentence to have exactly the opposite meaning, but I could be wrong. In any case, I don't mind one way or another, but I would like it to be correct and not confusing, so any help with the working will be welcome, because at this point I'm not sure which one of the 2 above is right. If you, or anyone else, can however confirm that the proposed wording is correct, it would be awesome.
(In reply to comment #8) > I did a try. It seems it has no effect. > > > static void _set_date_taken_as_posted_for_picture () > sounds very wrong. > > To clarify: > - DATE TAKEN, is the EXIF value, when the photo was taken. This should never be > changed. Date taken is never changed. Is the "date posted" value the one that is replaced with "date taken" value. Perhaps the wording is wrong, though (see my previous comment) > - DATE POSTED, is when the photo was uploaded to flickr. Flickr uses this value > to order the photo stream. Yes, that's the one that is being changed > - if you want your photo stream in the same order as you took the photos, you > need to change the DATE POSTED, and set it with the value of the DATE TAKEN. Yep, that's what this change does, besides the weird wording.
(In reply to comment #9) > (In reply to comment #8) > > I did a try. It seems it has no effect. > > actually it seems it had some effect, when the setting was... unchecked. > > Apparently, > > [x] Set 'Taken Date' as 'Posted Date' for Pictures > > --> does nothing > > [ ] Set 'Taken Date' as 'Posted Date' for Pictures > > --> set 'posted date' as 'taken date' That's weird. Perhaps I'm using the boolean value of the checkbox in the other way than the one it's intended for, which would be clearly a mistake. But I'd swear it worked as expected in the tests I did. (In reply to comment #10) > not sure anymore. Now it seems it worked correctly (with setting checked, it > reset the upload date). Maybe some side effect at some point? Very weird... the only thing I can think off is a problem in how the boolean value is read and used either in the preferences dialog or in the edit details dialog. Will check that when I have some more time, and probably do a new release right afterwards.
(In reply to comment #11) > (In reply to comment #7) > > in > > src/frogr-settings-dialog.c:_("Set 'Taken Date' as 'Posted Date' for > > Pictures"), > > > > it is "Set 'Posted Date' as 'Taken Date' for Pictures" > > not..."Set 'Taken Date' as 'Posted Date' for Pictures" > > > > hoping it's just a label issue, not a logic one > > Hmmm... I don't think the label is wrong. What I meant was "use the value of > 'date taken' and use it to set the value of 'date posted'", not the other way > around. > > It might be a problem with the wording (as a non-native English speaker I do > make quite some mistakes) but in my mind "Set 'Taken Date' _AS_ 'Posted Date'" > means what I explained above. > > Perhaps it's different if we say "set 'upload date' _TO_ 'taken date'", as you > wrote this bug's title? In my mind, changing "AS" for "TO" actually causes the > sentence to have exactly the opposite meaning, but I could be wrong. > > In any case, I don't mind one way or another, but I would like it to be correct > and not confusing, so any help with the working will be welcome, because at > this point I'm not sure which one of the 2 above is right. > > If you, or anyone else, can however confirm that the proposed wording is > correct, it would be awesome. OK, this might also be my English... My understanding is that when we say "Set A as B" it is similar to "Set the variable A with the value of B". But I can't tell for sure. Beside this potential wording, it now worked as a charm for many photos (thanks!). I noticed later that I had another frogr window open in another desktop, maybe it interfered? What I did now is: unset the setting, close the setting dialog, and reset the setting. I'll try to test if there is a corner case.
(In reply to comment #14) > > If you, or anyone else, can however confirm that the proposed wording is > > correct, it would be awesome. > > OK, this might also be my English... My understanding is that when we say "Set > A as B" it is similar to "Set the variable A with the value of B". But I can't > tell for sure. I guess we should ask a native speaker then :), or just use a different wording. What about "Replace 'Posted Date' with 'Taken Date'"? > Beside this potential wording, it now worked as a charm for many photos > (thanks!). I noticed later that I had another frogr window open in another > desktop, maybe it interfered? What I did now is: unset the setting, close the > setting dialog, and reset the setting. > Yes, that could certainly interfere, as both instances would write to the same settings.xml file. > I'll try to test if there is a corner case. Ok, many thanks!
I think I got it :), I changed that text to "Replace 'Date Posted' with 'Date Taken'": https://git.gnome.org/browse/frogr/commit/?id=2d789875b32675ae17e7ebbdeda91c43a1d963a5 Hope now it's more clear, less confusing or even both things at the same time! Btw, I'm now resolving it as fixed again as by your last comment.
(In reply to comment #16) > I think I got it :), I changed that text to "Replace 'Date Posted' with 'Date > Taken'": sounds good. I think that the confusion is that when we say "Set A as B", it can be understood in opposite ways depending on whether we consider A and B as variable and value or value and variable. Maybe.