After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734181 - possibility to select enemy's figure
possibility to select enemy's figure
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.14.x
Other Linux
: Normal minor
: ---
Assigned To: Sahil Sareen
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-02 17:34 UTC by Sergei Sinyak
Modified: 2015-01-10 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Reset the selected piece upon undo (846 bytes, patch)
2015-01-10 16:28 UTC, Sahil Sareen
accepted-commit_now Details | Review

Description Sergei Sinyak 2014-08-02 17:34:30 UTC
Stable reproducing: Touch your figure, capture an enemy's one, then touch your's again for further move, but press "Undo your recent move". Now the captured one looks like touched.
VERSION: 3.12.3
OS: Arch
Kernel: Linux version 3.15.7-1-ARCH (nobody@var-lib-archbuild-extra-x86_64-thomas) (gcc version 4.9.1 (GCC) ) #1 SMP PREEMPT Mon Jul 28 20:06:17 CEST 2014
Comment 1 Sahil Sareen 2014-12-25 15:58:56 UTC
Thanks for taking the time to report this bug.
This bug report isn't very useful because it doesn't describe the bug well. If you have time and can still reproduce the bug, please read http://bugzilla.gnome.org/bug-HOWTO.html and add a more useful description to this bug.
---
Can you please verify the steps to reproduce this issue.
Sorry, I couldn't understand from your description.

Touch your figure,  => Ok. Say white's chance
capture an enemy's one, => Ok. Captured a black. White's turn is over.
then touch your's again for further move, => Its black's turn, How can white move?
but press "Undo your recent move".
Comment 2 Sergei Sinyak 2014-12-25 23:28:13 UTC
Perhaps there is no check while undo: whether selected figure can be selected or not after undo, instead i see moving figures to previous positions with old selection.
Stable reproducing:
0) Find enemy's figure to be captured
1) Touch required figure
2) Capture enemy's figure
3) Let the enemy to make step so that not to kill you figure
4) Touch the figure from the 1st step
5) Press Undo once (or twice for Human vs Human mode)
6) Now, after undo you flying over board enemy's figure (i mean selected)
VERSION 3.14.1-1
OS: Arch
Comment 3 Sahil Sareen 2015-01-08 15:36:11 UTC
Sergei: Thanks for updating the bug.
I will try to fix this before the next release.
Comment 4 Sahil Sareen 2015-01-10 16:28:56 UTC
Created attachment 294231 [details] [review]
Reset the selected piece upon undo

This was an interesting bug!
Great find! :D
Comment 5 Michael Catanzaro 2015-01-10 16:45:01 UTC
Review of attachment 294231 [details] [review]:

I can't think of anything this might break. Go ahead and commit to master (but to be on the safe side, not to gnome-3-14).
Comment 6 Sahil Sareen 2015-01-10 18:46:24 UTC
Pushed into gnome-chess 3-15.