After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734165 - Use bookmark icons from icon theme
Use bookmark icons from icon theme
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other All
: Normal minor
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-02 09:53 UTC by David King
Modified: 2015-01-28 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
drop the bookmark icons and use the one from the icon theme (22.71 KB, patch)
2014-08-02 09:54 UTC, David King
committed Details | Review

Description David King 2014-08-02 09:53:07 UTC
Rather than using an appication-supplied set of bookmark icons, it would be better to use the user-bookmarks icon from the theme, which looks identical and is more appropriate that the existing add and remove icons.
Comment 1 David King 2014-08-02 09:54:10 UTC
Created attachment 282315 [details] [review]
drop the bookmark icons and use the one from the icon theme
Comment 2 Dominique Leuenberger 2015-01-23 10:52:05 UTC
for openSUSE, I got a bug report https://bugzilla.opensuse.org/show_bug.cgi?id=913866 which might benefit from this one here being fixed.

In short: the 'bookmark icon' looks out of proportion large (GtkBox is sized 50x50 instead of 34x34 as the others next to it).

Changing the icon at runtime (using gtk-inspector) to user-bookmarks-symbolic makes it fall in line with the other icons in the headerbar.
Comment 3 David King 2015-01-28 11:50:11 UTC
Review of attachment 282315 [details] [review]:

Acked by Shaun today, and pushed to master.