After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734163 - win32: giscanner should check for MINGW64
win32: giscanner should check for MINGW64
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
2.41.x
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-02 08:21 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2015-02-07 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check for MINGW instead of MINGW32 (953 bytes, patch)
2014-08-06 09:01 UTC, Ignacio Casal Quinteiro (nacho) 		committed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2014-08-02 08:21:47 UTC 
On this line https://git.gnome.org/browse/gobject-introspection/tree/giscanner/scannermain.py#n202
it is checked for MINGW32, although we should also check for MINGW64 which is set by the new 64bit msys.
Comment 1 LRN 2014-08-02 08:23:10 UTC 
Yes, that seems to be the logical conclusion.
Comment 2 Alexey Pavlov 2014-08-02 12:49:21 UTC 
More right in this case will be checking value with "starts with" like:

   msysenv = os.environ.get('MSYSTEM')
   if msysenv and msysenv.startswith('MINGW')
Comment 3 LRN 2014-08-02 12:57:11 UTC 
Also, m_option is never used, so this change you're proposing will have no effect either way.

There's another place where GI checks for MSYSTEM, in ccompiler.py, but that's a separate issue (and that code is going to be patched up soon, so we shouldn't intrude).
Comment 4 Ignacio Casal Quinteiro (nacho) 2014-08-06 09:01:53 UTC 
Created attachment 282643 [details] [review]
Check for MINGW instead of MINGW32

New versions of msys2 provide a MINGW64 env variable instead.
Comment 5 LRN 2014-08-06 09:07:36 UTC 
Review of attachment 282643 [details] [review]:

That should be OK.

That said, we should ask dieterv why he made -m<option> processing MSYS-only. GCC has a great number of -m options (Submodel-options), it has nothing to do with Windows.
Comment 6 Ignacio Casal Quinteiro (nacho) 2014-08-06 09:08:56 UTC 
Attachment 282643 [details] pushed as f530208 - Check for MINGW instead of MINGW32
Comment 7 André Klapper 2015-02-07 16:49:44 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]