After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734108 - Add a whitelist in addition to a black list for search providers
Add a whitelist in addition to a black list for search providers
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 734048 734109 734110
 
 
Reported: 2014-08-01 11:35 UTC by Giovanni Campagna
Modified: 2014-08-19 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a whitelist in addition to a black list for search providers (1.65 KB, patch)
2014-08-01 11:35 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-08-01 11:35:36 UTC 
We don't want to enable all search providers by default (for example
gnome-weather has privacy implications), so we can't use a simple
black list
Comment 1 Giovanni Campagna 2014-08-01 11:35:38 UTC 
Created attachment 282246 [details] [review]
Add a whitelist in addition to a black list for search providers
Comment 2 Bastien Nocera 2014-08-05 10:47:11 UTC 
Review of attachment 282246 [details] [review]:

::: schemas/org.gnome.desktop.search-providers.gschema.xml.in.in
@@ +29,3 @@
+      <default>[]</default>
+      <_summary>
+        List of desktop file IDs for which default-disabled search provider that

I can't parse this sentence.
Comment 3 Giovanni Campagna 2014-08-19 13:25:51 UTC 
Pushed with a better key description.
Attachment 282246 [details] pushed as ef6bb91 - Add a whitelist in addition to a black list for search providers

gsettings-desktop-schemas 3.13.90 was released without this patch, but
gnome-control-center 3.13.90 uses the new key, so you probably want to
do a 3.13.90.1
Comment 4 Bastien Nocera 2014-08-19 17:05:17 UTC 
(In reply to comment #3)
> Pushed with a better key description.
> Attachment 282246 [details] pushed as ef6bb91 - Add a whitelist in addition to a black
> list for search providers
> 
> gsettings-desktop-schemas 3.13.90 was released without this patch, but
> gnome-control-center 3.13.90 uses the new key, so you probably want to
> do a 3.13.90.1

3.13.91 release done.
Comment 5 Bastien Nocera 2014-08-19 17:12:56 UTC 
Bump requirements in g-c-c as well.