After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734026 - [PATCH] Support libvala-0.26
[PATCH] Support libvala-0.26
Status: RESOLVED FIXED
Product: gnome-code-assistance
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Code Assistance maintainers
GNOME Code Assistance maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-31 08:33 UTC by Ville Skyttä
Modified: 2014-11-21 04:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[backends/vala] Support libvala-0.26 (825 bytes, patch)
2014-07-31 08:33 UTC, Ville Skyttä 		accepted-commit_now Details | Review

Description Ville Skyttä 2014-07-31 08:33:19 UTC 
Created attachment 282125 [details] [review]
[backends/vala] Support libvala-0.26

The attached patch makes g-c-a buildable with libvala-0.26. I believe I have commit access, let me know if you'd like me to try pushing this.
Comment 1 Ignacio Casal Quinteiro (nacho) 2014-07-31 09:52:56 UTC 
Review of attachment 282125 [details] [review]:

Looks good.
Comment 2 jessevdk@gmail.com 2014-07-31 20:54:34 UTC 
I wonder if we should try to make this more future proof somehow.
Comment 3 Ville Skyttä 2014-08-02 07:48:56 UTC 
Pushed as rev bf3a800.

(In reply to comment #2)
> I wonder if we should try to make this more future proof somehow.

Maybe talk to the libvala people and ask if they could help out with it, e.g. by installing an unversioned *.pc or shipping autotools macros that would do the tricks necessary to make this stuff easier for downstream consumers?
Comment 4 Tristan Brindle 2014-11-21 04:33:47 UTC 
The Fedora 21 package for g-c-a currently doesn't include the Vala backend (rh #1126628) as it's based on the 0.3.1 release. Would it be possible to make a new release of g-c-a with this fix so that the Fedora package can be updated?
Comment 5 Tristan Brindle 2014-11-21 04:39:36 UTC 
Gah, the downstream bug is #1123628, sorry

https://bugzilla.redhat.com/show_bug.cgi?id=1123628