GNOME Bugzilla – Bug 733978
Grub menu on a 1920x1080 hiDPI screen is unreadabl
Last modified: 2016-03-31 13:22:00 UTC
I have a small realtively high rez screen ( not high rez enough to trigger hiDPI mode, but still higher than normal in DPI, 12inch at 1920x1080) With this setup, Boxes showing grub menu text is actually impossible to read if you're slightly beyond perfect eyesight.
Created attachment 282057 [details] Screenshot Now imagine that this is on a 13.3" laptop. I think we should enable some upscaling by default if there is a "large text" accessibility option is on. I.e. if the configured dpi is more than 96.
I agree this is unfriendly and should be improved, and Boxes used to scale up in this case cerca 2y ago, but it was changed, see https://bugs.freedesktop.org/show_bug.cgi?id=54277 for the rationale (the bug was opened for Boxes, see commit 4153421381) Perhaps the right fix for this bug was to keep the aspect ratio instead, but still scale up.
(In reply to comment #2) > I agree this is unfriendly and should be improved, and Boxes used to scale up > in this case cerca 2y ago, but it was changed, see > https://bugs.freedesktop.org/show_bug.cgi?id=54277 for the rationale (the bug > was opened for Boxes, see commit 4153421381) > > Perhaps the right fix for this bug was to keep the aspect ratio instead, but > still scale up. So shall we reopen that bug? Is there something Boxes should be doing?
I would suggest upscaling while keeping ratio, that way at least text will be readable.
In any case, shouldn't this bug be on spice instead?
spice-gtk display does provide properties: scaling & only-downscale
(In reply to comment #6) > spice-gtk display does provide properties: scaling & only-downscale Yeah but does it keep aspect ratio now? I'm asking cause you said: > Perhaps the right fix for this bug was to keep the aspect ratio instead, but > still scale up. Also, I don't really see any rationale on the spice bug for 'only-downscale' other than "This is what is desired". Is it a work-around for lack of aspect-ratio being maintained when scaling up?
Created attachment 288813 [details] Screencast of aspect ratio being maintained while scaling Disabling 'only-downscale' and doing some quick testing suggests that aspect-ratio is maintained.
In any case, I'll disable 'only-downscale' now since: 1. This only affects the case of no auto-resolution working in guest and I hope thats not the most common one. 2. If I'm wrong about aspect-ratio being maintained while scaling up, it should be fixed on spice side IMO.
Created attachment 288816 [details] [review] spice-display: Don't set 'only-downscale' prop on display Setting this only makes the display very tiny on hidpi screens when no autoresolution is in effect (e.g grub screen or guests with no qxl/agent). Lets not ask spice to only downscale but rather always scale the display to fit in its window.
Review of attachment 288816 [details] [review]: Patch looks good per se and seems to work. However it would be nice if we snap at the native resolution as well as duplicates of it so the user gets a sharp image. You know what I mean? May be an own bug though.
(In reply to comment #11) > Review of attachment 288816 [details] [review]: > > Patch looks good per se and seems to work. However it would be nice if we snap > at the native resolution as well as duplicates of it so the user gets a sharp > image. You know what I mean? May be an own bug though. No clue of what you are talking about. :)
Attachment 288816 [details] pushed as 456f377 - spice-display: Don't set 'only-downscale' prop on display
(In reply to comment #12) > (In reply to comment #11) > > Review of attachment 288816 [details] [review] [details]: > > > > Patch looks good per se and seems to work. However it would be nice if we snap > > at the native resolution as well as duplicates of it so the user gets a sharp > > image. You know what I mean? May be an own bug though. > > No clue of what you are talking about. :) If you try to resize the boxes window to fit exactly the resolution of the host - you probably wont succeed because you aren't as precise with your mouse. So you need boxes to 'snap' the window size to the host resolution if you're near it. Gnome shell does the same thing when you try to align windows beneath each other.
(In reply to comment #9) > In any case, I'll disable 'only-downscale' now since: > > 1. This only affects the case of no auto-resolution working in guest and I hope > thats not the most common one. > > 2. If I'm wrong about aspect-ratio being maintained while scaling up, it should > be fixed on spice side IMO. You'll have the same issue with gtk-vnc: the aspect-ratio has been implement on virt-viewer side, spice-gtk gives you the freedom to do any ratio you want, just resize the widget approprietely. But hey, feel free to send a patch!
(In reply to comment #14) > (In reply to comment #12) > > (In reply to comment #11) > > > Review of attachment 288816 [details] [review] [details] [details]: > > > > > > Patch looks good per se and seems to work. However it would be nice if we snap > > > at the native resolution as well as duplicates of it so the user gets a sharp > > > image. You know what I mean? May be an own bug though. > > > > No clue of what you are talking about. :) > > If you try to resize the boxes window to fit exactly the resolution of the host > - you probably wont succeed because you aren't as precise with your mouse. So > you need boxes to 'snap' the window size to the host resolution if you're near > it. Maybe it would be a good enhancement but its one of those for which I'll only want an open bug if there is patches attached (at least for now). :)
(In reply to comment #15) > (In reply to comment #9) > > In any case, I'll disable 'only-downscale' now since: > > > > 1. This only affects the case of no auto-resolution working in guest and I hope > > thats not the most common one. > > > > 2. If I'm wrong about aspect-ratio being maintained while scaling up, it should > > be fixed on spice side IMO. > > You'll have the same issue with gtk-vnc: the aspect-ratio has been implement on > virt-viewer side, spice-gtk gives you the freedom to do any ratio you want, > just resize the widget approprietely. But hey, feel free to send a patch! 1. As I said and showed (see attachment#288813 [details]) aspect-ratio *is* maintained. 2. With me handling most of the Boxes development alone, I'd rather leave spice bugs to spice devs.
*** Bug 686330 has been marked as a duplicate of this bug. ***