After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733948 - src/libtracker-extract/tracker-extract-info.c: Non-void function should return a value
src/libtracker-extract/tracker-extract-info.c: Non-void function should retur...
Product: tracker
Classification: Core
Component: General
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: tracker-general
Depends on:
Reported: 2014-07-30 03:26 UTC by Ting-Wei Lan
Modified: 2014-07-30 10:18 UTC
See Also:
GNOME target: ---
GNOME version: 3.13/3.14

Fix "Non-void function should return a value" (919 bytes, patch)
2014-07-30 03:30 UTC, Ting-Wei Lan
accepted-commit_now Details | Review

Description Ting-Wei Lan 2014-07-30 03:26:55 UTC
In src/libtracker-extract/tracker-extract-info.c, tracker_extract_info_get_media_art_process uses g_return_if_fail, which should be replaced by g_return_val_if_fail.
Comment 1 Ting-Wei Lan 2014-07-30 03:30:21 UTC
Created attachment 281991 [details] [review]
Fix "Non-void function should return a value"
Comment 2 Martyn Russell 2014-07-30 08:00:03 UTC
Comment on attachment 281991 [details] [review]
Fix "Non-void function should return a value"

Nice catch, thank you Ting-Wei. Please go ahead and commit - or let me know if you want me to do it :)