After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733915 - NMClient: disconnect the connectivity check cancellable signal after the call has ended
NMClient: disconnect the connectivity check cancellable signal after the call...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: API
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-29 12:50 UTC by Giovanni Campagna
Modified: 2014-09-19 18:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NMClient: disconnect the connectivity check cancellable signal after the call has ended (1.26 KB, patch)
2014-07-29 12:50 UTC, Giovanni Campagna 		none Details | Review

Description Giovanni Campagna 2014-07-29 12:50:29 UTC 
We cannot rely on connectivity data freeing to disconnect the signal,
because the simple async result might be kept alive by external
code (for example the language runtime for JS), but we must not
call dbus_g_proxy_cancel_call() if that cancellable is cancelled or
reused afterwards.
Comment 1 Giovanni Campagna 2014-07-29 12:50:31 UTC 
Created attachment 281946 [details] [review]
NMClient: disconnect the connectivity check cancellable signal after the call has ended
Comment 2 Dan Williams 2014-08-01 01:56:17 UTC 
Pushed to master, 0.9.10, and 0.9.8, thanks!