After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733899 - TelepathyClient: fix history trimming
TelepathyClient: fix history trimming
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: telepathy
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-29 07:15 UTC by Giovanni Campagna
Modified: 2014-08-19 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
TelepathyClient: fix history trimming (2.20 KB, patch)
2014-07-29 07:15 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-07-29 07:15:15 UTC 
We need to put the actual actors in the history, not just the labels,
otherwise all emptyLine (which are not messages but are not empty
either) and all lines with a timestamp will get stuck in the scrollback.
Comment 1 Giovanni Campagna 2014-07-29 07:15:17 UTC 
Created attachment 281911 [details] [review]
TelepathyClient: fix history trimming
Comment 2 drago01 2014-08-03 16:23:13 UTC 
Review of attachment 281911 [details] [review]:

Didn't test but code looks good to me.
Comment 3 Giovanni Campagna 2014-08-19 14:48:11 UTC 
Attachment 281911 [details] pushed as 7c9d90b - TelepathyClient: fix history trimming