After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733871 - Support the new GtkTextView draw_layer vfunc
Support the new GtkTextView draw_layer vfunc
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
git master
Other Windows
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-28 15:09 UTC by Alexander Larsson
Modified: 2014-07-28 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use the new GtkTextView draw_layout vfunc to fix icon-cache rendering (11.76 KB, patch)
2014-07-28 15:09 UTC, Alexander Larsson
none Details | Review

Description Alexander Larsson 2014-07-28 15:09:28 UTC
I just added GtkTextView.draw_layer and reverted 1ac13435b7c14dd9b97ad7a9d292acd51337d66e. This means we have to update gtksourceview to fix rendering of things like current row and right margin highlight.
Comment 1 Alexander Larsson 2014-07-28 15:09:55 UTC
Created attachment 281871 [details] [review]
Use the new GtkTextView draw_layout vfunc to fix icon-cache rendering

Rather than draing things before and after chaining up to the
textview draw vfunc we use the new draw_layout vfunc to do
these draws at the correct place. This fixes drawing as the new
TextView now 1) draws the background, 2) uses an pixel cache, which
makes the previous approach not work.
Comment 2 Alexander Larsson 2014-07-28 18:28:03 UTC
commited to master