After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733848 - PortalHelper: fix portals that don't redirect properly
PortalHelper: fix portals that don't redirect properly
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-28 07:39 UTC by Giovanni Campagna
Modified: 2014-08-19 13:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PortalHelper: fix portals that don't redirect properly (4.91 KB, patch)
2014-07-28 07:39 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-07-28 07:39:37 UTC 
We assumed that either a portal would give us a target URI, or we
would eventually reach the URI of our choice (which is http://www.gnome.org)

This is not always the case: even after a successful login we may
stay in a confirmation page, so make sure that every time we see a
redirect we trigger a connectivity check (or queue one for when
the user closes the window)
Comment 1 Giovanni Campagna 2014-07-28 07:39:40 UTC 
Created attachment 281841 [details] [review]
PortalHelper: fix portals that don't redirect properly
Comment 2 Rui Matos 2014-08-01 16:55:28 UTC 
Review of attachment 281841 [details] [review]:

Can't test this but the logic looks fine
Comment 3 Giovanni Campagna 2014-08-19 13:30:43 UTC 
This was extensively tested at Guadec.

Attachment 281841 [details] pushed as b6e6e09 - PortalHelper: fix portals that don't redirect properly