After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733842 - submodule xorg-macros naming is a little confusing
submodule xorg-macros naming is a little confusing
Status: RESOLVED DUPLICATE of bug 727962
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2014-07-28 00:42 UTC by Magdalen Berns (irc magpie)
Modified: 2014-12-24 13:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rename xorg-macros to xorg-x11-util-macros (3.23 KB, patch)
2014-07-28 00:49 UTC, Magdalen Berns (irc magpie)
committed Details | Review

Description Magdalen Berns (irc magpie) 2014-07-28 00:42:40 UTC
Running

pkcon search name xorg-macro

does not bring up the missing dep package for xorg-macro.pc.

A search and install of xorg-x11-util-macros allows xorg-macro.pc to be found by 
jhbuild which suggests that assigning "xorg-x11-util-macros" to the dep package variable instead of "xorg-macros" would be more likely to help jhbuild/the user find the right package.
Comment 1 Magdalen Berns (irc magpie) 2014-07-28 00:49:43 UTC
Created attachment 281835 [details] [review]
rename xorg-macros to xorg-x11-util-macros
Comment 2 Frederic Peters 2014-07-28 06:57:44 UTC
How did you get to a message mentioning xorg-macros?  As it's available in your distribution packages it should have been automatically found and installed.

The package is named xutils-dev on Debian/Ubuntu and I prefer to keep things neutral.
Comment 3 Magdalen Berns (irc magpie) 2014-07-28 07:20:23 UTC
(In reply to comment #2)
> How did you get to a message mentioning xorg-macros?  As it's available in your
> distribution packages it should have been automatically found and installed.
> 
> The package is named xutils-dev on Debian/Ubuntu and I prefer to keep things
> neutral.

I imagine the reason it's not being found has something to do with the "xorg-macro" rpm package not existing ;-). 

For the desired xorg-macro.pc to be found jhbuild and the user alike, would both need to look for the rpm packagexorg-x11-util-macros in order to find a package to install.
Comment 4 Magdalen Berns (irc magpie) 2014-07-28 07:26:39 UTC
(In reply to comment #2)
> The package is named xutils-dev on Debian/Ubuntu and I prefer to keep things
> neutral.

That's all well and good, but neither of those package names for xorg-macro would be found by jhbuild and it is also not obvious how to find them manually due to how the different package names are to the moduleset definition for this package. 

It would be better to indicate how to get hold of the right package manually since jhbuild cannot find it as is neither on debian packages or rpm, I imagine.
Comment 5 Frederic Peters 2014-07-28 07:49:17 UTC
> I imagine the reason it's not being found has something to do with the
> "xorg-macro" rpm package not existing ;-). 

Not at all, for jhbuild the important part is not the package name but the .pc file it refers,

  <systemmodule id="xorg-macros">
    <pkg-config>xorg-macros.pc</pkg-config>
    <branch repo="system"/>
  </systemmodule>

And it should be found automatically, if it's not, that's a bug, but changing module name wouldn't fix it.
Comment 6 Magdalen Berns (irc magpie) 2014-07-28 08:06:27 UTC
(In reply to comment #5)
> > I imagine the reason it's not being found has something to do with the
> > "xorg-macro" rpm package not existing ;-). 
> 
> Not at all, for jhbuild the important part is not the package name but the .pc
> file it refers,
> 
>   <systemmodule id="xorg-macros">
>     <pkg-config>xorg-macros.pc</pkg-config>
>     <branch repo="system"/>
>   </systemmodule>
> 
> And it should be found automatically, if it's not, that's a bug, but changing
> module name wouldn't fix it.

In filing the bug it was already established that a bug existed. You can chose to believe me or not, there, it's up to you. So, assuming I haven't made up that this is a bug for giggles and that goes without saying what is it that you think will fix this bug (considering this bug which is caused by jhbuild looking for a package by its .pc name when the rpm/.deb package has not the same name)?
Comment 7 Frederic Peters 2014-07-28 09:52:55 UTC
In order to properly locate, then fix, the bug, I had that question before,

> How did you get to a message mentioning xorg-macros?

This would really help as the bug report starts at "running pkcon search" but doesn't mention the jhbuild parts that got you to try that command.
Comment 8 Magdalen Berns (irc magpie) 2014-07-28 16:44:01 UTC
(In reply to comment #7)
> In order to properly locate, then fix, the bug, I had that question before,
> 
> > How did you get to a message mentioning xorg-macros?
> 
> This would really help as the bug report starts at "running pkcon search" but
> doesn't mention the jhbuild parts that got you to try that command.

Sure. To recreate try

jhbuild sysdeps --install

when this dependency is not install and you should find that it does not get found or installed on running that command.
Comment 9 Frederic Peters 2014-07-29 01:17:13 UTC
What's your distribution?   On recent versions of Fedora it should call to "yum -y install pkgconfig(xorg-macros.pc)"; what is the output of jhbuild you get? what's the output of the yum command I gave?
Comment 10 Magdalen Berns (irc magpie) 2014-07-29 14:35:51 UTC
I need to uninstall macros then I will upload the output for you, give me a few moments. Thanks.
Comment 11 Frederic Peters 2014-07-29 14:38:28 UTC
Sure; thank you. (problably I won't have time to look at it immediately, but it will help when I get back to it).
Comment 12 Magdalen Berns (irc magpie) 2014-07-29 20:27:52 UTC
Ok here it is. Let me know if you need anything further

(In reply to comment #9)
> What's your distribution?

Fedora 20

> what is the output of jhbuild you get?

E: Unable to set arguments (327688, 1, [u'pkgconfig(libmusicbrainz5)', u'pkgconfig(smbclient)', u'pkgconfig(libsystemd)', u'pkgconfig(libxklavier)', u'pkgconfig(xorg-wacom)', u'pkgconfig(json)', u'pkgconfig(lcms2)', u'pkgconfig(xtrans)', u'pkgconfig(avahi-gobject)', u'pkgconfig(gmime-2.6)', u'pkgconfig(alsa)', u'pkgconfig(mozjs-17.0)', u'pkgconfig(poppler-glib)', u'pkgconfig(bluez)']) according to signature u'tas': <type 'exceptions.TypeError'>: 'int' object is not iterable
process 9582: arguments to dbus_message_get_destination() were incorrect, assertion "message != NULL" failed in file dbus-message.c line 3376.
This is normally a bug in some application using the D-Bus library.
  D-Bus not built with -rdynamic so unable to print a backtrace


> what's the output of the yum command I gave?

bash: syntax error near unexpected token `('
Comment 13 Frederic Peters 2014-07-29 21:47:43 UTC
(In reply to comment #12)
> > what is the output of jhbuild you get?
> 
> E: Unable to set arguments (327688, 1, [u'pkgconfig(libmusicbrainz5)', […]

Ok, that's bug 727962, the packagekit API changed and jhbuild only speaks the previous version.

> > what's the output of the yum command I gave?
> 
> bash: syntax error near unexpected token `('

It missed quotes, sorry, it should have been yum -y install "pkgconfig(xorg-macros.pc)".

*** This bug has been marked as a duplicate of bug 727962 ***
Comment 14 Magdalen Berns (irc magpie) 2014-07-30 02:36:56 UTC
(In reply to comment #13)
> (In reply to comment #12)
> > > what's the output of the yum command I gave?
> > 
> > bash: syntax error near unexpected token `('
> 
> It missed quotes, sorry, it should have been yum -y install
> "pkgconfig(xorg-macros.pc)".

sudo yum -y install "pkgconfig(xorg-macros.pc)"
Loaded plugins: langpacks
No package pkgconfig(xorg-macros.pc) available.
Error: Nothing to do

Then I reinstalled the package xorg-x11-util-macros and did a search for 
xorg-macros.pc file:
/home/magpie/jhbuild/checkout/macros
/usr/share/pkgconfig
Comment 15 Colin Walters 2014-07-30 11:48:01 UTC
Isn't this the PK API break bug?  I can't find it offhand, basically PK changed the API jhbuild uses.
Comment 16 Colin Walters 2014-07-30 11:49:06 UTC
Drop the .pc, i.e.:

udo yum -y install "pkgconfig(xorg-macros)"
Comment 17 Magdalen Berns (irc magpie) 2014-07-30 11:54:22 UTC
(In reply to comment #16)
> Drop the .pc, i.e.:
> 
> udo yum -y install "pkgconfig(xorg-macros)"

Yep that works to install packages. Still get the same error on running jhbuild sysdeps --install but this is probably the fastest way to work around that and install the require packages, I think.
Comment 18 Magdalen Berns (irc magpie) 2014-07-30 11:56:56 UTC
(In reply to comment #17)
> (In reply to comment #16)
> > Drop the .pc, i.e.:
> > 
> > udo yum -y install "pkgconfig(xorg-macros)"
> 
> Yep that works to install packages. Still get the same error on running jhbuild
> sysdeps --install but this is probably the fastest way to work around that and
> install the require packages, I think.

Although note that this doesn't work:

sudo yum -y install "pkgconfig(libsystemd)"
Loaded plugins: langpacks
No package pkgconfig(libsystemd) available.
Error: Nothing to do
Comment 19 Frederic Peters 2014-07-30 11:58:11 UTC
(In reply to comment #15)
> Isn't this the PK API break bug?  I can't find it offhand, basically PK changed
> the API jhbuild uses.

It is bug 727962; I marked this one as a duplicate.  (probably the other one needs a better title, I had trouble finding it).
Comment 20 Colin Walters 2014-07-30 13:18:45 UTC
(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > Drop the .pc, i.e.:
> > > 
> > > udo yum -y install "pkgconfig(xorg-macros)"
> > 
> > Yep that works to install packages. Still get the same error on running jhbuild
> > sysdeps --install but this is probably the fastest way to work around that and
> > install the require packages, I think.
> 
> Although note that this doesn't work:
> 
> sudo yum -y install "pkgconfig(libsystemd)"

It's pkgconfig(systemd)  - without the lib.

This data is generated from the files in /usr/lib64/pkgconfig.
Comment 21 Allison Karlitskaya (desrt) 2014-12-24 01:04:12 UTC
Review of attachment 281835 [details] [review]:

Did this get committed by accident?
Comment 22 Magdalen Berns (irc magpie) 2014-12-24 13:01:18 UTC
(In reply to comment #21)
> Review of attachment 281835 [details] [review]:
> 
> Did this get committed by accident?

Seems so, yes:

https://git.gnome.org/browse/jhbuild/commit/modulesets/gnome-suites-core-deps-3.14.modules?id=3d5353b6a7bc086cf2e25781009f6eeedab101f0

Looking at the dates it seems like the patch was hanging around in my local repo so when something else that was accepted got pushed for JHBuild that got pushed too. Sorry! I should have checked that properly.

Is it causing problems? Shall I revert it?