After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733748 - No accessible state-changed signals are emitted when the state of buttons in a document are toggled
No accessible state-changed signals are emitted when the state of buttons in ...
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-25 16:27 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2014-08-04 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (6.56 KB, patch)
2014-07-25 16:27 UTC, Joanmarie Diggs (IRC: joanie) 		none Details | Review
proposed patch (6.58 KB, patch)
2014-07-30 15:51 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2014-07-25 16:27:33 UTC 
Created attachment 281703 [details] [review]
proposed patch

When the state of buttons is toggled, there is no accessible event notifying assistive technologies that the state has changed.
Comment 1 Joanmarie Diggs (IRC: joanie) 2014-07-25 16:31:26 UTC 
(In reply to comment #0)
> Created an attachment (id=281703) [details] [review]
> proposed patch

Note that this patch might seem like overkill just for toggling buttons. But there are other instances where we will need to notify assistive technologies of state changes, and there may be multiple states that need to be updated at once for a given object.
Comment 2 Joanmarie Diggs (IRC: joanie) 2014-07-30 15:51:46 UTC 
Created attachment 282088 [details] [review]
proposed patch

Master-compatible version of the previous patch
Comment 3 Carlos Garcia Campos 2014-07-31 09:12:50 UTC 
Review of attachment 282088 [details] [review]:

Ok.
Comment 4 Joanmarie Diggs (IRC: joanie) 2014-08-04 14:22:59 UTC 
Comment on attachment 282088 [details] [review]
proposed patch

https://git.gnome.org/browse/evince/commit/?id=4599025