Bug 733729 – typefind: do not reject reconfigure event when signalling new caps

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 733729 - typefind: do not reject reconfigure event when signalling new caps


Summary:	typefind: do not reject reconfigure event when signalling new caps


Status:	RESOLVED OBSOLETE

Product:	GStreamer
Classification:	Platform
Component:	gstreamer (core)
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	git master
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-07-25 10:39 UTC by Vincent Penquerc'h
Modified:	2018-11-03 12:21 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
typefind: do not reject reconfigure event when signalling new caps (2.54 KB, patch) 2014-07-25 10:39 UTC, Vincent Penquerc'h	none	Details \| Review

Description Vincent Penquerc'h 2014-07-25 10:39:33 UTC

Created attachment 281683 [details] [review]
typefind: do not reject reconfigure event when signalling new caps

Not sure whether this is 100% right, so putting that up for comments.

It avoids the event being rejected as we're about to switch (but too late) to normal mode. Not sure if there'd be other event types we'd want to let through here too.

Comment 1 Tim-Philipp Müller 2018-01-27 12:16:23 UTC

I don't see any problem with this, just wondering what it actually fixes.

Does it fix some real issue or does it just avoid failure reports in the log file?

Could also just let reconfigure events through unconditionally in the patch.

Comment 2 GStreamer system administrator 2018-11-03 12:21:40 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/67.