GNOME Bugzilla – Bug 733711
Remove couple of dead conditions.
Last modified: 2014-07-26 20:42:43 UTC
Created attachment 281656 [details] [review] Remove couple of dead conditions. "xmlIO.c" if (filename == NULL) return(NULL); Above conditions already checks if filename is NULL. No need to do Null check again for path. as path=filename; "xmlmemory.c" p = (MEMHDR *) malloc(RESERVE_SIZE+size); if (!p) { goto error; } It already checks if P is NULL. s = (char *) HDR_2_CLIENT(p); It assigns some memory of p, so cannot be Null. so, checking s to NUll is not required. Please apply attached patch.
For the first one I preferred to change the coding slightly to avoid the risk of generating a NULL pointer if more cases were added there. Second patch fine :-) Applied and fixed in git, thanks ! Daniel