After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733700 - Tabs are missing borders
Tabs are missing borders
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Tabs
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-24 21:59 UTC by António Fernandes
Modified: 2014-08-28 00:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Restore borders of tabs in css (968 bytes, patch)
2014-07-24 22:04 UTC, António Fernandes 		none Details | Review
Restore borders of tabs in css (904 bytes, patch)
2014-08-27 09:34 UTC, António Fernandes 		committed Details | Review

Description António Fernandes 2014-07-24 21:59:16 UTC 
Selected tab doesn't have the left and right borders nor the blue bottom border, as shown in this screenshot: https://bugzilla.gnome.org/attachment.cgi?id=281608
Other tabs are also missing borders on hover.

I think this was introduced in this commit: https://git.gnome.org/browse/nautilus/commit/?id=3fd7e847d531fbbfc4ebba24864bdd0f8b81c750

> +NautilusNotebook.notebook {
> + border-right-width: 0;
> + border-left-width: 0;
> + border-bottom-width: 0;
> +}

Removing the above lines fixes this bug. I didn't notice any negative effect to removing them, perhaps they are not needed anymore.
Comment 1 António Fernandes 2014-07-24 22:04:04 UTC 
Created attachment 281641 [details] [review]
Restore borders of tabs in css

This patch removes the lines quoted in comment 0.
Comment 2 António Fernandes 2014-08-27 09:34:42 UTC 
Created attachment 284590 [details] [review]
Restore borders of tabs in css

Updated patch.
Comment 3 Cosimo Cecchi 2014-08-28 00:04:13 UTC 
Looks good, pushed to master.

Attachment 284590 [details] pushed as 8fae3a8 - Restore borders of tabs in css