After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733697 - parse: Unref reference to enclosing bins
parse: Unref reference to enclosing bins
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 1.2.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-24 20:09 UTC by Sebastian Rasmussen
Modified: 2014-07-28 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch plugging memory leak. (966 bytes, patch)
2014-07-24 20:10 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-07-24 20:09:25 UTC 
When looking for code that accidentally forgot to unref the returned element reference from gst_bin_get_by_name() I found that gst_parse_add_delayed_set() leaks the reference to each enclosing bin of an element. This is easily remedied by the attached patch.
Comment 1 Sebastian Rasmussen 2014-07-24 20:10:31 UTC 
Created attachment 281634 [details] [review]
Proposed patch plugging memory leak.
Comment 2 Thiago Sousa Santos 2014-07-28 12:27:18 UTC 
Thanks, pushed for core.

master:
commit 08870205811e5b88cdcb2efc89e4130954218b8d
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Thu Jul 24 22:02:58 2014 +0200

    parse: Unref reference to enclosing bins
    
    Previously all reference to enclosing bins of an element were leaked
    when doing delaying setting a property.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=733697

1.4:
9fe3365f94f02473ac7e40a2d4ab5c787b175a87

1.2:
861ca3d6787d84c9bea7110cb46821e9b8f63aff