GNOME Bugzilla – Bug 733684
Nautilus tabs are bigger than any other application
Last modified: 2014-09-04 22:37:44 UTC
Created attachment 281608 [details] nautilus tabs Bug is visible in screenshot
Also, the blue line is missing from the selected tab.
nautilus needs apps specific fixes for that, which are not in the theme anymore, so it needs to ship the css for that. That specific issue can be fixed with this css: NautilusNotebook.notebook tab { border-width: 0px 1px 3px; } NautilusNotebook.notebook tab .button { padding: 0px; }
Created attachment 283788 [details] [review] Fix Adwaita.css styles for tabs
Created attachment 283789 [details] Screen after patch
I don't think that looks entirely right either, the tabs should not that space between them. Lapo, can you take a look?
(In reply to comment #5) > I don't think that looks entirely right either, the tabs should not that space > between them. Lapo, can you take a look? It is a standard GTK theming space, in all apps.
(In reply to comment #6) > (In reply to comment #5) > > I don't think that looks entirely right either, the tabs should not that space > > between them. Lapo, can you take a look? > > It is a standard GTK theming space, in all apps. It happens because I have in active Tab in hover
Created attachment 283830 [details] without hover
Review of attachment 283788 [details] [review]: Looks good
(In reply to comment #7) > It happens because I have in active Tab in hover Oh that explains it then... Patch looks good to me.
Cosimo the gap between tabs is intended. Fix looks good to me.
Pushed to master now.
Created attachment 285404 [details] nautilus 3.13.91 tabs This issue is still on 3.13.91. I downloaded 3.13.91 tarball and Adwaita.css doesn't have this fix. Was it removed in another commit?
(In reply to comment #13) > Created an attachment (id=285404) [details] > nautilus 3.13.91 tabs > > This issue is still on 3.13.91. I downloaded 3.13.91 tarball and Adwaita.css > doesn't have this fix. Was it removed in another commit? I don't know what you're missing, you need both latest GTK+ and Nautilus. It seems to work fine from upstream
Yeah, it was a previous version of GTK+. It doesn't happen with the latest version. I'm sorry for the noise.