After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733657 - cerbero: Add openjpeg recipe
cerbero: Add openjpeg recipe
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: packages
unspecified
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-24 10:41 UTC by Lubosz Sarnecki
Modified: 2014-07-24 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add openjpeg recipe and add to bad plugins (2.89 KB, patch)
2014-07-24 10:41 UTC, Lubosz Sarnecki
needs-work Details | Review
Added to codecs package (3.59 KB, patch)
2014-07-24 14:27 UTC, Lubosz Sarnecki
committed Details | Review

Description Lubosz Sarnecki 2014-07-24 10:41:20 UTC
Created attachment 281569 [details] [review]
Add openjpeg recipe and add to bad plugins

This patch adds JPEG2000 support to cerbero.
The build is inspired by the Arch Linux openjpeg package.
Comment 1 Sebastian Dröge (slomo) 2014-07-24 11:00:22 UTC
Did you get it to build on Windows, Android, iOS and OSX? I tried that myself some time ago and then just gave up because cmake was wasting too much time ;)
Comment 2 Lubosz Sarnecki 2014-07-24 11:03:46 UTC
I just tried the native Windows build.

I am in fact using autotools in the build. The 1.5.1 release from Google Code is very funky with a different build. Arch also uses the SourceForge 1.5.2 release.
Comment 3 Sebastian Dröge (slomo) 2014-07-24 11:08:26 UTC
Comment on attachment 281569 [details] [review]
Add openjpeg recipe and add to bad plugins

openjpeg:libs needs to be added to the gstreamer-1.0-codecs.package

Also why not use openjpeg2?
Comment 4 Lubosz Sarnecki 2014-07-24 11:21:23 UTC
I saw that openjpeg 2 exists, but I thought the plugin in bad depends on 1.5, since I suspected API change. I will try if it works with OpenJPEG2.
Comment 5 Sebastian Dröge (slomo) 2014-07-24 11:24:45 UTC
It works with both versions, but the OpenJPEG2 API is worse and slower :)
Comment 6 Lubosz Sarnecki 2014-07-24 14:27:50 UTC
Created attachment 281598 [details] [review]
Added to codecs package

Well if the 2.0 is slower and worse, then I guess 1.5.2 is fine?

Arch usually always adapts the most recent release, I wonder why they still are on 1.5.2.
Comment 7 Sebastian Dröge (slomo) 2014-07-24 14:48:42 UTC
Yes, I think 1.5.2 is ok
Comment 8 Sebastian Dröge (slomo) 2014-07-24 14:51:03 UTC
commit d4ad6b3b509fa67d8d1c4e107077f397ed594ed7
Author: Lubosz Sarnecki <lubosz@gmail.com>
Date:   Fri Jul 25 10:39:05 2014 +0200

    recipes: Add openjpeg and include it in gst-plugins-bad
    
    https://bugzilla.gnome.org/show_bug.cgi?id=733657
Comment 9 Sebastian Dröge (slomo) 2014-07-24 16:47:58 UTC
commit a6dfbac333f449de71842751768e62884ead52de
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Jul 24 18:41:06 2014 +0200

    openjpeg: Include pkg-config files