After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733656 - Improve the close notification buttons
Improve the close notification buttons
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-24 10:20 UTC by Debarshi Ray
Modified: 2014-07-30 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
notifications: Turn off relief and focus-on-click for close button (1.17 KB, patch)
2014-07-24 10:22 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-07-24 10:20:56 UTC 
The close notification button in Boxes has its relief and focus-on-click set to false. Does not make much difference for the indexing notification, but is more noticeable in the delete notification which has two buttons.

By the way, why don't we use a GdNotification for each notification (like Boxes) instead of stuffing them as GtkGrids into a single GdNotification? I am asking because little details like the close button are already solved by GdNotification.
Comment 1 Debarshi Ray 2014-07-24 10:22:39 UTC 
Created attachment 281568 [details] [review]
notifications: Turn off relief and focus-on-click for close button
Comment 2 Debarshi Ray 2014-07-30 13:29:22 UTC 
Comment on attachment 281568 [details] [review]
notifications: Turn off relief and focus-on-click for close button

Pushed, after talking to Cosimo at the BoF.